@isaacnovaes
Posted
Hey @danielden!
Great job! Your solution looks great. Also, the idea of displaying the country's weather and localization is awesome. However, I have a few suggestions:
- If I go to any country detail and reload the page, your website crashes. I think that you should look into it
- For a tablet dimension, for example, 811 x 860, all border country buttons are stacked in a column, leaving too much space which could be better used. So fixing it could improve the UI and the responsiveness
- If a country has no currencies, nothing is displayed. I think that at least a "no currency" message should be displayed
- If a country has no border, like Antarctica, a UI button with "no countries" text is displayed. I think that only a simple text fits best here instead of a UI button because, in this border countries section, a button links you to another country
Marked as helpful
@denielden
Posted
@isaacnovaes thanks for your suggestions, we will fix them as soon as possible!
I am afraid that the first point is due to the configuration of the netlify environment... I will delve into the bug
Thanks again :)
@isaacnovaes
Posted
@denielden yep, thatโs exactly it. Normally, for every request, the hosting server sends a different HTML, CSS, and JS files. However, when we use React Router, we donโt want this behavior, since with React Router our app is a SPA, i.e. only one HTML file. So we should set the hosting server to always direct the path for the index.html, because whenever the URL changes, React Router will take care of what should be displayed.
Thankfully, it is easy to do. Check out this Youtube video
Marked as helpful
@denielden
Posted
@isaacnovaes Wow! Thank you so much :)