@stephmunez
Submitted
Hey everyone!
I just completed another challenge. 🤘🏽
Feedback is always welcome. Please let me know of any issues you may find and/or how I can improve my code :)
Happy coding!
Looking to hire developers?
@ixtk
@stephmunez
Submitted
Hey everyone!
I just completed another challenge. 🤘🏽
Feedback is always welcome. Please let me know of any issues you may find and/or how I can improve my code :)
Happy coding!
@ixtk
Posted
Hey, looks like the images are being stretched. They lose aspect ratio. Avoid setting width directly, use max-width
. Right now you can apply object-fit
rule on the images. Look it up!
@imonaar
Submitted
Laying the bg images was a little troublesome. Used js to feed the prices.
comments and corrections are welcome.
@ixtk
Posted
body::before
creates horizontal scrollbar on big monitor screens. Also, it appears that if I hover buttons on left or right, it affects the rest of them by adding 1px border
Marked as helpful
@Andrii-Rohov
Submitted
Hello. In this project i tried to set all font-sizes and other stuff to viewport width(vw) unit, hope you would check it and point out the errors.
@ixtk
Posted
I wouldn't recommend using wv
unit for font-sizes. The problem is that if user changes their font size in settings, your website doesn't adapt. It also doesn't change font size if user zooms in/out. So it is only responsive to width of the window, which is not ideal. On some widths, font looks way too big/small (743px, 764px)
Other than that, consider adding main
element and check the report
Marked as helpful
@lizardcoder9999
Submitted
Please give me feedback so I can keep improving.
@ixtk
Posted
h1
on the website, consider using it for "Group Chat for Everyone" text.intro__title
is not centered on desktop layoutfont-size: inherit
main
element in html to indicate which part of the page is the main contentThere are other layout issues like images not being centered on mobile screen or top images messing up layout. Make sure to use browser dev tools to inspect how different elements/layout will look on different screen sizes. If you have specific questions feel free to ask
@Karl-Wilson
Submitted
Please feedback on what to improve on will be appreciated. You can take a look at the project and advice me on what to improve on for instance view rendering issues, code structure, folder structure etc. Thanks
@ixtk
Posted
The website says "loading". It doesn't seem to work
@Yuko-code
Submitted
This is my 8th FM challenge. I couldn't display the number thing (the ones in circles with vertical line on top) at the bottom properly.
@ixtk
Posted
You can remove the padding and add display: grid
and place-items: center
to center the text in the circle. Give the bottom one white background color.
There's horizontal scrollbar at about 1200px
Marked as helpful
@dyoba10
Submitted
Theres a purple line below the img in mobile view, i dont know how to fix it. any feedback would be appreciate :)
@ixtk
Posted
block
. This gets rid of little space below it that looks like paddingrem
and em
and why they're importantMarked as helpful
@AhmadAbouAlaynain1
Submitted
Did I use too many classes throughout the HTML? How would I go about making this more efficient with respect to lines of code and reusability.
@ixtk
Posted
h3
. I think classes come up when layout is more complicated and it would be pain to nest many many levels of selectors<p>
for card bodies (semantic HTML!).cards
) since .container
does the same thing. You could have defined <div class="card-container">
. Similarly, there are many unnecessary div
s, for example, you didn't need to wrap button
or icon image in a divdisplay: flex
does anything for .card
meaning you don't need it<a>
in the button, so user wouldn't be redirected anywhere when clicking the button. I suggest using <a>
, or if you want to use button for some reason, nest <a>
inside to make it a link (you should probably only use <a>
for purpose of links)I think this one is little over-complicated. I suggest you think about in terms of little components when coding small sections instead of whole websites.
Good luck!
Marked as helpful
@riteessshh
Submitted
Feedbacks are appreciated.
@ixtk
Posted
The logo text in the footer is supposed to be white; Using <p>
for footer navigation links makes no sense, you can't be redirected to another page if this was multiple pages
@itsagift
Submitted
I'm still not 100% sure about the mobile solution padding.
@ixtk
Posted
object-fit: cover
.bottom
have no margin next to each other. The texts almost touch each other. Use row-gap
or column-gap
for space in between children if your layout is either flex or gridimg
for those icons and not nest them in div
.bottom
as grid
the whole time. There's no need to display it as flex, just have either 2 or 1 column depending on the size of the screen.border-radius
the side they're touching browser edge onThe way I did the snapping part is gave section container fixed padding, like 24px
and then used margin-[left/right]: -24px
on the image.
Don't forget to check the report
Marked as helpful
@maciekw129
Submitted
That's my first such big React project. I will be grateful for any suggestions and feedback ;)
@ixtk
Posted
Looks good.
I would go from 1 to 2 columns instead of 3 right away. You should really add alt
texts for images as the report suggests.
@Locky-Becken
Submitted
If someone can rate my code, I would appreciate it.
@ixtk
Posted
.info_content
as flex accomplishes nothing, as it would look exactly the same width default display: block
display: flex
and margin-right: 3rem
to .info_content
, add column-gap: 3rem
on parent .info
.Don't forget to check the report
@heritio
Submitted
This one was a challenge with vanilla javascript, would be easier to do with react, but i would like to hear fro you on how i would make this project better on file organisation and such, otherwise thanks for the feedback.
@ixtk
Posted
font-size
is very small in modalcursor: pointer
to the modal close button and radio checkbox sectionAlso, check the report
When it comes to folder structure, this from pro membership challenge files has become my new template
- assets
- mobile
- tablet
- desktop
- shared (for icons that appear on all layouts, maybe logo.svg)
- css
- style.css
- js
- main.js
.gitignore
index.html
Marked as helpful
@juanpb96
Submitted
Any comments on my solution will be appreciated! 😄
@ixtk
Posted
Clean.
I feel like full width button on tablet layout is overkill though. I would move it up sooner. (I don't know if it was in the design, just my opinion)
@GerLC
Submitted
Was going to separate the scss in modules.
@ixtk
Posted
width: 50
or flex-basis: 50%
to ensure they will only take half of the screen and won't span more than that.width: 100%
to image containerclamp()
to not allow more than some number of charactersThese are just few issues, if you have specific questions feel free to ask
Also, check the report
@gwhitdev
Submitted
I learned a lot about the Grid with this challenge. I think there's probably some efficiencies that I can make in the CSS, possibly with the actual grid layout itself.
@ixtk
Posted
Some notes
row-gap
, column-gap
, or gap
instead of grid-*
since it has been deprecated. Now you can even apply gaps to flexbox layout.testimonial
needs display: grid
since there's only one child inside#three
has incorrect grid-row
value, it's supposed to start from row 1 and end at 3. You have it start at 2 and end at 3. This makes extra auto row appear. If you inspect with dev tools you'll see there's row-gap
applied at the end of .grid
. That's always hint that unwanted extra row got added and you need to fix the grid-row
value of one of the childrenMarked as helpful
@DavidMaillard
Submitted
Hi !!
Feedbacks are welcome !!
🤘🤘🤘
@ixtk
Posted
Looks great!
One little thing: header links have no color change hover state the way footer does (I don't remember if this was required)
I like that you've used img
tags for photography and design section. I used background-image
and background-size: cover
and sometimes the text overlapped with the fruit and I had to find sweet spot for position. It stays nice and clean in your solution!
I would use section
tag for testimonials section, and maybe the standout and transform divs could have been section
too.
Also, font-size
doesn't scale if I change default browser settings which might get annoying for some users. I would use relative units there.
Don't forget to check the report
@Hikki666
Submitted
Any feedback is appreciated.
@ixtk
Posted
box-sizing
propertyrem
or em
for font-size
, and margin
and padding
around text. I've changed my default font-size
in browser but the learn more button stayed the same size, which is not good for user experiencecursor: pointer
when hovering over learn morea
tag instead of button
tag for "learn more" because right now that button can't redirect me to any other page. It doesn't have the href
attribute. You could put a
inside the button
but It's better to use a
tag on its own for links@tusharaseri
Submitted
Is there any short methods for media queries or some tips for responsive design Constructive criticism is appreciated.
@ixtk
Posted
font-size
, use rem
, em
or other relative unit for thatem
and rem
for paddings and margins around text. This will ensure that text has enough/appropriate breathing space when font size changes.h1
s in one pageh2
-h6
tags to identify what the it's abouth5
you've used should have been a p
tagpara
you've usedMarked as helpful
@H3lltronik
Submitted
I used JS to filter the countries instead of the API but it was kind of slow when typing fast so I debounced the filter query, I hope it isn't slow
Any kind of feedback is welcome.
@ixtk
Posted
When I set light mode, click some country and go back to main page, it reverts to dark mode. Also, don't forget to check the report
Marked as helpful
@Galielo-App
Submitted
The hero section, omg...
Very hard! I was dealing with overflows, z-index, a lot of stuff that complicated everything lol! But that's it, I feel way more comfortable working with that weird stuff now.
But overall, I liked the final result. What do you guys think?
@ixtk
Posted
Very clean, I love it. Make sure to check the report and fix the issues though
How did they manage to get the greyscale photo into that purple color? Could I have made it for responsive with flexbox or do I need to look at CSS grid? Could I have used semantic html more?
@ixtk
Posted
There's no need to use grid here, you can make this particular component fully responsive with only flexbox.
Few problems:
border-radius
to the componentSuggestions:
vw
and vh
units. Instead let the content grow or shrink the component and set margin for the sides on the parent elements. Maybe set max-width
section
HTML tag for this componentmargin
from body
Regarding purple background color:
You could have added a separate div
with purple background color, then used position
property to position it on top of the image and give it little bit of opacity.
Easier approach would be to use background-blend-mode
property. Check that out
PS: Check the website report
@rquispeq
Submitted
Suggestions for make it more responsive please.
@ixtk
Posted
Flexbox and grid layout will make this easier to deal with. Definitely check them out.
Marked as helpful
@Impriceless
Submitted
Any feedbacks would be appreciated!!
@ixtk
Posted
Looks good.
features
grid items are not centered.features
and companies
sectionsYou can check out clamp()
function in css for fluid font size