Skip to content
OverviewSolutions
6
Comments
3

James

@jamescheinLondon160 points

Artist and Web Designer

Latest solutions

Latest comments

  • James•160
    @jameschein

    Hi Mr Enthusiast, You made a great job of the UI with some good lean HTML structure and fine CSS work.

    Some pointers - // The functionality is missing for changing the cards - is this to come?

    // The HTML and class naming could be more semantic and obvious - eg <main> might benefit from a class of 'advice__card'. Even better would be to use a <div class="advice__app> or landmark element [section, article, etc] inside the <main> element which is traditionally used as a top level page structure element like <header> and <footer> etc. This would serve you better if you wanted to port the advice application as a self-contained component wholesale to other sites in future.

    Hope this helps. Best to you! James :)

    Marked as helpful
  • James•160
    @jameschein

    Hey Alexander

    This was a very helpful solution. Looking under the hood, everything is very pretty and clean including the wonderfully clear README file in your repository. I will definitely be taking a lesson from this in future project.

    Also, while this was my first real but messy attempt at incorporating an API, yours was a lean pleasure to behold.

    I was focused on things like making the advice container stay still and same size as the quotes changed. Had to use some container with container smarts to effect this but got there in the end. I also randomised the page load.

    Now, I must go and make my die spin ;)

    Cheers, James

  • James•160
    @jameschein

    Lovey stuff. All the extra touches make yours an interesting extended challenge tutorial. I was struggling to use :hover pseudo to create a toggle to no avail - of course an input element is a good solution for this job of a CSS toggle. Although, I am still wondering if there is any way to use a button element as a toggle in CSS for a maybe more elegent and semantically solid solution?

    May I recommend a link around all the individual news or second-level story blocks content and fixing them up so when you roll over any part of a story the headline is highlighted and a click anywhere on the story will take you to the associated page.

    Many thanks. Very useful.

    Marked as helpful