Jose Chaparro
@jchapar
All comments
- Jose Chaparro• 455
@jchapar
Posted
Amazing Job on this Jeff! Your site looks good on mobile, tablet and desktop view points! I have to say its not to often the project/challenge slider looks almost identical. Appreciate the feedback given on my challenge. Happy Coding!
0 - iago• 400
@iagohenrique2009
Submitted
Any feeback of how i improve my code?
Jose Chaparro• 455@jchapar
Posted
Hey Iago! Nice work on this challenge. Once thing I noticed in you styles is that you put JUSTIFY-CONTENT twice in the Main elements styles. First time as Center and the second as Flex-Start. If you're looking to center the content it would be best to do Justify-Content and Align-Items as center. I'm guessing you went with a Desktop first approach and this should help center you content on desktops.
Marked as helpful
1 - Jose Chaparro• 455
@jchapar
Submitted
Hello Everyone, any feedback would be greatly appreciated! Would love to get some advise on how I could have matched the design better. Darker overlay, content width etc.
Jose Chaparro• 455@jchapar
Posted
I redid the HTML markup and went with a mobile approach when it came to styling it. I feel happy that this version looks a lot better than the first submission. The one thing I've been having an issue with is the dark violet line underneath the image. I'm still currently looking but haven't been able to figure out why this line is visible on mobile and not desktop.
0
