Rino raj• 260
@rinoraj6
Submitted
John Mirage
@john-mirage
All comments
- John Mirage• 1,610
@john-mirage
Posted
Hello, nice work
Here some ways you can improve your project:
- The button has no hover effect
- The social media links have no hover effects
- You should add a feature that close the tooltip when you click outside of it.
- You should add a button for the share button instead of a div so users can select and open the tooltip with a keyboard.
1 - Pkaoutar ouadih• 350
@kaoutar-ouadih
Submitted
What are you most proud of, and what would you do differently next time?
I proud of completing this challenge!
What challenges did you encounter, and how did you overcome them?
how to make the row height dynamic and fit the content.I solved that using grid-auto-rows: auto
What specific areas of your project would you like help with?
Anything that can help me improve.
John Mirage• 1,610@john-mirage
Posted
Hello, nice work
Here some ways you can improve your project:
- You should consider moving your css in a different file, it is more clean this way.
- You should add a container for the cards so the width is fixed and the cards dont stretch.
- In the <head> you forget to rename the <title>
- To help you start a project, you can add a css reset file. It defines some rules to ease your workflow.
- You can add meta tags in your <head> element to display informations and an image for Google and the social medias like facebook and twitter.
- The images can be converted in webp format, webp format compress images more so you get less loading time.
0 - lij110397• 230
@lij110397
Submitted
What are you most proud of, and what would you do differently next time?
1. How to use flex box and grid to build responsive layout
- Use flex box. Be familar with attributes like "flex-wrap","align-items","justify-content" and so on.
form { display: flex; align-items: flex-end; flex-wrap: wrap; gap: 16px; } .name { flex-grow: 1; flex-basis: 160px; } .email { flex-grow: 3; flex-basis: 200px; } button { flex-grow: 1; flex-basis: 80px; }- Use fluid type and space This makes the font size changing accordingly. It is based on a useful tool - utopia. But in this case, I only use "--step-0".
:root { --step--2: clamp(0.6rem, 0.5032rem + 0.4128vi, 0.8748rem); --step--1: clamp(0.75rem, 0.629rem + 0.5161vi, 1.0935rem); --step-0: clamp(0.9375rem, 0.7863rem + 0.6451vi, 1.3669rem); --step-1: clamp(1.1719rem, 0.9829rem + 0.8063vi, 1.7086rem); --step-2: clamp(1.4648rem, 1.2286rem + 1.0079vi, 2.1357rem); --step-3: clamp(1.8311rem, 1.5358rem + 1.2599vi, 2.6697rem); --step-4: clamp(2.2888rem, 1.9197rem + 1.5749vi, 3.3371rem); --step-5: clamp(2.861rem, 2.3996rem + 1.9686vi, 4.1714rem); }- Use relative unit like rem
- Use media quires when necessary.
What challenges did you encounter, and how did you overcome them?
How can I develop the desktop design without using media quires, but using flex box or grid only?
I added one media query and in larger screen I used grid and specifically put different elements in different columns.
What specific areas of your project would you like help with?
How can I develop the desktop design without using media quires, but using flex box or grid only?
John Mirage• 1,610@john-mirage
Posted
Hello, nice work !!
Why do you want to avoid using media queries ?
0 - Thedgmz98• 50
@Thedgmz98
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud the way I did this and the excellent time management doing this. That was great!!
What challenges did you encounter, and how did you overcome them?
I have some problems with the H1 because in desktop was supposed to be with some line jumps, and on mobile just two. But i barely fixed showing another H tag to make it work.
What specific areas of your project would you like help with?
Responsive design and font styling
John Mirage• 1,610@john-mirage
Posted
Hello, nice work !!
Here some ways you can improve your project:
- In the <head> of your project, you loaded more fonts than the project need, you can remove the links who are not needed.
- To help you start a project, you can add a css reset file. It defines some rules to ease your workflow.
- You can add meta tags in your <head> element to display informations and an image for Google and the social medias like facebook and twitter.
- The product images can be converted in webp format, webp format compress images more so you get less loading time.
- Check out the BEM methodology, it can help you for the naming of your classes
- You forget to add a favicon in the <head> element.
Marked as helpful
1 - Timelessgreed• 70
@Timelessgreed
Submitted
What are you most proud of, and what would you do differently next time?
It's a great project
What challenges did you encounter, and how did you overcome them?
The margins and paddings
What specific areas of your project would you like help with?
the margins and paddings
John Mirage• 1,610@john-mirage
Posted
Hello, nice work !!
Here some ways you can improve your project:
- Your card has a fixed width, you can make it responsive by adding a relative width of 100% and a max-width of 460px so the card will shrink when the screen width in under 460px
- To help you start a project, you can add a css reset file. It defines some rules to ease your workflow.
- You can add meta tags in your <head> element to display informations and an image for Google and the social medias like facebook and twitter.
- The omelette image can be converted in webp format, webp format compress images more so you get less loading time.
- Your page overflows on the right (on my screen) because your wrapper has a width of 100vw, removing this rule fix the issue.
- For the nutrition section, you can use a <table> element.
- There is a left padding on the lists by default, you can remove them by adding
padding: 0on the <ul> or <ol> elements. - Your project do not contains media queries, you can add some to make your project fully responsive.
Marked as helpful
0 - Bhuvan• 40
@bhuvandev16
Submitted
What are you most proud of, and what would you do differently next time?
- I'm most proud of the clean and visually appealing design I created for the social link web page
What challenges did you encounter, and how did you overcome them?
- One challenge I encountered was aligning elements properly across different screen sizes. I overcame this by utilizing CSS Flexbox to ensure responsive design.
What specific areas of your project would you like help with?
- I would appreciate help in improving the user experience through advanced CSS techniques, such as animations or transitions, to make the page more engaging.
John Mirage• 1,610@john-mirage
Posted
Hello, nice work !!
Here some ways you can improve your project:
- You can remove the underlines of your links by adding the
text-decoration: none;rule. - Your card has a fixed width, you can make it responsive by adding a relative width of 100% and a max-width of 350px so the card will shrink when the screen width in under 350px
- There is no paddings around the card, you can add some horizontal paddings to make the card breathe on mobile device
- To help you start a project, you can add a css reset file. It defines some rules to ease your workflow.
- The card has lower paddings on mobile than on desktop, you can add a media querie to reflect this behavior.
- The social links can be placed in <li> elements surrounded by an <ul> element.
- You can add meta tags in your <head> element to display informations and an image for the social medias like facebook and twitter.
- You can define the inter font on the <body> element so the font spread accross all the children elements.
- The hover effect should only be applied to the devices who have hover feature, you can add a media querie to target those devices with
@media screen and (hover: hover) {}
0 - phemmyils• 80
@phemmyils
Submitted
What are you most proud of, and what would you do differently next time?
This project allowed me to develop strong time management skills and ensure independent completion
What challenges did you encounter, and how did you overcome them?
none
What specific areas of your project would you like help with?
media queries
John Mirage• 1,610@john-mirage
Posted
hello, nice work
here are some ways to improve your project
- You can add meta tags for social media so your project in well represented on facebook twitter etc.. metatags
- You can generate favicons for all the devices on this website
- Use html semantic tags to surround your content in the body, it is better for accessibility and SEO (<main> <header> <footer> etc...).
- You can use the BEM methodology for the name of your classes, it helps a lot.
- You should try to use REM instead of px for the sizes, it is better.
The project require some media queries for the texts. You can add them with:
.text { font-size: 1rem; } @media screen and (min-width: 576px) { .text { font-size: 1.5rem; } }The rules defined on the text class will be apply when the screen is 576px of width minimum, so before 576px the text will be 1rem and after 1.5rem.
Marked as helpful
0 - Pandretrindade13• 80
@andretrindade13
Submitted
What are you most proud of, and what would you do differently next time?
Using flex-box to test delivery of this first challenge. For the next challenges I hope to use some CSS preprocessor and apply some development patterns to organize the classes
What challenges did you encounter, and how did you overcome them?
The biggest challenge now is to make up for lost time without practicing front-end development, I spent 4 years developing only in node, now I'm focusing back on full-stack web development to start new challenges as an entrepreneur
What specific areas of your project would you like help with?
I would like tips on patterns and tools that I can study to improve front development, with more speed and if there are other development approaches such as using react or another framework to deliver the challenges
John Mirage• 1,610@john-mirage
Posted
Hello, nice work
Here some ways you can improve your project
- Use semantic HTML like <main> <header> <footer> etc... tags to surround your content so people with screen reader know where they are on the page.
- Use a <h1> tag for the main title of your content, it is important for people using screen readers, they cannot know that this is a title unless you use a heading tag. It also help with SEO.
- Before starting a project you can use a css reset file to have some rules to help you writting css.
- You should add a link on the image so users who don't want to scan the qr code can visit the website anyway.
- You used a fixed width on the card, you should use a relative width like 100% and use a max-width of 320px so the card will stay the same but shrink if the device viewport is less than 320px of width.
- Prefer using REM instead of PX for the sizes.
- You used a height of 100vh for the container, you should use a min-height instead so the viewport can go further than 100vh if the screen height is less than your card height.
Marked as helpful
0 - Troy Insixiengmay• 110
@Tascate
Submitted
Is this a good use case of CSS grid? I decided to try to use it after seeing the two-column layout of the desktop design.
John Mirage• 1,610@john-mirage
Posted
Hello,
This is not a bad case for grid because you can make it works like you did, but maybe flexbox is better for a simple layout like this one.
0 - Clinto Bean• 130
@clintonclark1995
Submitted
Hello! Thank you for checking out my solution for this challenge.
This is my first attempt at using vanilla javascript for validation, and did not create individual validation functions for each scenario, rather, I used a sweeping function to check for invalid dates, leap years, etc.
I did my best to get the design as pixel-perfect as possible, but I am sure there are mistakes.
What I am looking for feedback on most are the following.
- Positioning, I struggled a lot with getting the submit button to be where I needed.
- Javascript syntax, while I understood what I needed to do, I had to use chatGPT to help me correct my syntax because I kept running into errors, specifically the validation functions.
I am more used to using things such as react which use a virtual DOM and components, so vanilla JS is foreign to me but something I believe is vital to learn before I continue into react, svelte or anything else.
John Mirage• 1,610@john-mirage
Posted
Hello,
I strongly encourage you to learn vanilla js before any framework or meta framework you can find. I did the same at first (react before vanilla) and it was really not the best choice at all, basically, knowing vanilla js can help you a lot for everything you do in the javascript world including working with frameworks.
Marked as helpful
1 - Marius• 110
@drangam9
Submitted
I used position:absolute to center the card in the middle of the webpage.
Is there a better/efficient way to center it? Is this method good enough? Thanks in advance.
John Mirage• 1,610@john-mirage
Posted
Hello,
yes flexbox or grid can help you center the card, they should be a better option than absolute position because the card stay in the flow, so it may be a better practice.
1 - John Robert Maizo• 360
@johnmaizo
Submitted
Hello guys, I find challenging on the hero section, where the two photos of the right side are merging, also my SCSS code is not so clean. Anyways, I would greatly appreciate your valuable feedback on this solution.
John Mirage• 1,610@john-mirage
Posted
Hello,
The hero images setup is one of the hardest to achieve, so don't blame yourself if it's not perfect :) here is my project if you want to see how i did it.
1 - Javier Eufracio• 260
@Javieer57
Submitted
I would like to include Storybook in the project. Could you recommend any resources to learn the best practices for Storybook?
John Mirage• 1,610@john-mirage
Posted
Hello,
For storybook, you can start with the official website which is great. I saw you are using nextjs so in the options at the top of the guide choose: latest version 7.0, React and Javascript. The storybook script
npx storybook@latest initshould automatically detect your project btw.0 - PWessel Konstantinov• 350
@WesselKonstantinov
Submitted
This is my first premium challenge. It was quite interesting. I decided to use absolute positioning for the decorations and also the error message in order to prevent the podcast icons from shifting on larger viewports.
In terms of accessibility, how do you think the form validation looks? Would it be better to also include attributes such as
aria-invalidandaria-required?The design did not include a "success" state for submitting the form, so I went with a simple alert that displays the submitted email address. This is only for demonstration purposes, as there is probably a better solution for showing a success state.
John Mirage• 1,610@john-mirage
Posted
Unfortunately, i don't have the answer to your question but, my advice is to download and install NVDA (for Non Visual Desktop Access) (if you are on mac or linux there are alternatives) and try your application by yourself and eyes close (no cheating !!!) xD and see if you are able to understand what to do and where you are.
Marked as helpful
1 - Abhiram• 90
@abhiram-s21
Submitted
how do i add background colour over the image?
how would i make the image appear on top in mobile design?
John Mirage• 1,610@john-mirage
Posted
hello,
To display the image on top on mobile and on the right on desktop, you can use flex, first simply put the image first in html then the text section so you have the image on top, then in desktop use flex to display the elements in a row and change the order of the elements with the order css property so the image is second and the text section is first.
Marked as helpful
2 @jeffreylaichunghang
Submitted
The difficult part is the media query. It looks like that I have to redefine the sizes, width and height all over again. My css looks like a mess, not quite readable. I am still figuring out a way to reduce the use of class.
John Mirage• 1,610@john-mirage
Posted
Hello, did you wrote the css from mobile to desktop ?, if not it's maybe a better idea to go mobile first, it should be easier and more readable (and it's a best practice because of the mobile devices performances)
0- jmurrii• 10
@jmurrii
Submitted
Couldn't work out why the margin for the h1 was different for rem and em.
I thought that the h1 should inherit the font-size from the html element where I set the font-size to 62.5% ?
John Mirage• 1,610@john-mirage
Posted
Hello,
Root EM watch the html element, EM watch the element itself or the first parent that has a font-size even by default.
My guess is that if you have REM your h1 watch the html element so it will be relative to 62.5% and if you have EM it will be relative to the default size of a h1 (h1 has a default font-size)
Marked as helpful
1 - mirshod455• 10
@mirshod455
Submitted
Could you recommend me the right way of structurize my css code.
John Mirage• 1,610@john-mirage
Posted
Hello,
I recommend you the BEM css methodology to organize your code.
0 - ishu• 80
@ishukhatri
Submitted
I've managed to create a visual design that appears satisfactory. However, when compared to the original Figma design, I notice minor discrepancies of a few pixels. What strategies could I employ to address these differences? Additionally, what are the best practices for defining the width and height of main container components?
John Mirage• 1,610@john-mirage
Posted
Hello,
My advice considering the pixel perfect dilema is that you should not try to be perfect, but you should try to find the best experience and the best consistency with the measurement. That way it's easier in the code and it is still a nice UI experience. But really, differences between the design and the website are fine as long as you can explain why. The vast majority of the time i'm not pixel perfect but i use a measurement scaling that make sens (4px 8px 16px 32px 48px etc...)
Marked as helpful
0 - Faye• 30
@FayeVinyl
Submitted
I was unable to figure out how to add the corner borders to the summary section. I'm certain my css could be cleaner. I learned a lot about flexbox
John Mirage• 1,610@john-mirage
Posted
hello,
The corner border ??? you mean the shadow ?? if so this is the box-shadow css property.
1 - Zubair Abid• 280
@ZubairAbid101
Submitted
Q1 Any best practices that I may be missing? Q2 Are there any other ways to center an element without using flexbox > align-items > justify-content?
John Mirage• 1,610@john-mirage
Posted
Hello,
You also can use absolute position to center an element but it will be out of the flow.
html
<div class="container"> <div class="element"></div> </div>css
.container { position: relative; width: 500px; height: 500px; background-color: blue; } .element { position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); width: 200px; height: 200px; background-color: red; }0 - chirikchekmen• 240
@skyrimer
Submitted
The card is simple and doesn't take a lot of time to do. The only question I have is the hover effect of the image. The view icon and cyan background has different opacity. What I did is that I used two pseudo-elements, but is it possible to do just with one, considering I am using css variables, so the use of
hslais not an option?John Mirage• 1,610@john-mirage
Posted
Hello,
I dont really understand your question, but i can say that you can have a background image and a background-color on the same element, you center the image and yes you use a transparent color with hsla or rgba css function so no need of opacity in this one.
0 - jessicadong101• 20
@jessicadong101
Submitted
I found the CSS to be difficult. I'm unsure about my layout and if it matches the solution as well as the responsiveness to different screen sizes. I'm unsure about HTML, CSS, and JS best practices.
John Mirage• 1,610@john-mirage
Posted
Hello,
HTML
- It should be better to use a form for your inputs and button so you can submit.
- your inputs should have a label indicating what the user should input (<label></label>) and the labels should be linked to the inputs with an id.
CSS
- check the BEM css methodology to organise css selectors, it can help you organize css files
- if you use flex to have two elements in a row, you need to setup the elements inside (flex: 1 or flex: 0) so flex knows what he should do (shrink or/and grow). your button is not round because of that.
Javascript
- best practice is to use const or let but not var anymore because of the scope
Marked as helpful
0 - Soham• 100
@sommmmore
Submitted
I am new to learning JavaScript. This was my attempt at building a working project with basic JS. Any suggestions or advice on how I can improve are welcome!
John Mirage• 1,610@john-mirage
Posted
Hello,
For the submit button, you added letter spacing by adding one space character between the letters, don't forget the nice css property: letter-spacing which add some space between the letters for you.
Marked as helpful
1
