Skip to content
OverviewSolutions
9
Comments
3
Karthik SP
@karthisp

All comments

  • Karthik SP•110
    @karthisp

    Great work Rohit.

    Just a few suggestions

    • Give <html>, <body>, #container a height of 100% and align #container to the 'center' using align-items CSS property for flex.
    Marked as helpful
  • Karthik SP•110
    @karthisp

    Great Job.

    Looks very close to the original design.

    Just a few suggestions

    1. increase the 'letter-spacing' for button text
    2. Increase line height for <p>
    3. 1 rem margin for '.rating_component' and <h1> should be good enough
  • Karthik SP•110
    @karthisp

    Hi @MelvinAguilar you've done a great job with implementing the given design. Keep up the good work. I've got a lot of things to learn from you.

    Just a small suggestion:

    I see that you've used clip for sr-only (H1), instead try using clip-path. Apparently, that's what is recommended. https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path