Skip to content
OverviewSolutions
10
Comments
3

Massimiliano Cornale

@mcornaleItaly350 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Massimiliano Cornale•350
    @mcornale

    Hi @diaasaur, great job!

    One thing I would suggest you is to sync the filters with the url. Imagine you add to this project pagination, one user should be able to reload and see just what he needs, for example: page 2 of invoices with status paid. It is typically a good thing in web apps! If you want, check my solution of this challenge!

    Marked as helpful
  • Massimiliano Cornale•350
    @mcornale

    Hi @jdnCreations!

    I would suggest you to keep the App file as clean as possible. Ideally, the best practice is to have one component per file. You could also improve how to convert the UI into components, this should be a process that you do before starting to code. I suggest you to read through this page of the React docs (https://react.dev/learn/thinking-in-react).

    For example you could have splitted things like this: One component per step: PersonalInfoStep, SelectPlanStep, AddOnsStep, SummaryStep Then in the App you could have stored the current step state and with that deciding what step component to show.

    Also, one thing that can help you is to create a "ui" folder inside the "components" folder to put there all reusable ui elements like buttons, inputs, ecc.. This allows you to keep project structure clean and don't repeat code.

    Marked as helpful
  • Massimiliano Cornale•350
    @mcornale

    Hi @pawelpikus,

    I think you could have used less divs using only p tags when there was only text inside of the element. Also u could have wrapped all the messages in a container div with a padding to give the space around all the screen of the mobile element.

    You can have a look at my implementation if u want.

    Thank you,

    Happy coding 😊