@Shall-Fade
Submitted
Looking to hire developers?
@ndro
@Shall-Fade
Submitted
Hi, nice solution with Vue
I don't know if this is only me or others too. But, when I ran your site in Firefox (or Edge too), I got an error when the status is not Lose or Draw. Only Lose and Draw won't error. With Chrome, your solution is perfect.
Maybe you can check in Firefox. But if it's run, then it's just me, hehe...
Good work
Marked as helpful
@WickedBlack
Submitted
Any feedback is welcome, please feel free to suggest anything.
is it ok to use "em" and "rem" values for margin and padding? Or should those values only be used for fonts? because I was using "%" to set some values but was not sure what is best.
I had a lot of difficulty with the social media icons. The borders around them are different sizes for each icon, I can't get them all to look the same.
Hi, 👏 congrats for completing the challenge
I think it's ok to use rem
or em
. Some people use px
for 1px or little size, then use rem
for rest. Consistency is better.
For social media icons, you can try to use an SVG tag and then edit the style for width
and height
. Font-awesome provides it.
<svg xmlns="http://www.w3.org/2000/svg" style="width: 16px; height: 16px" viewBox="0 0 320 512" fill="currentColor"> </svg>
Everything is nice! 🤘
Marked as helpful
@Viha123
Submitted
The second page works on my local machine, but I don't know why I see the 404 error on the server. I wasn't able to figure out the javascript part of the second page. Help on that would be extremely appreciated.
Hi, 👏 congrats for completing the challenge
Maybe some function was not found. I can not find where the function getSelection()
is.
<a href= "/thankYou.html" onclick = "getSelection()" class = "submit">SUBMIT</a>
or there was another JS that didn't push to your repository, like index2.js
. I saw it on index.html
but the file wasn't there.
Additionally, your page is not yet responsive.
Everything is nice! 🤘
@RthR2
Submitted
If anyone has any tips, I'm open to new learnings.
Hi, 👏 congrats for completing the challenge
Maybe just a little advice but it's nice to try. You can edit background-image
URL with double dot (.) like this url(../images/bg-desktop.svg);
same as mobile section too.
Everything is nice! 🤘
@eyagargah
Submitted
Any comment is appreciated :)
Hi, 👏 congrats for completing the challenge
Maybe you can try editing the button width
to 13%
to make it rounded and color: white
to make the font white.
Everything is nice! 🤘
@lulam
Submitted
Any and all feedback is welcomed. Please let me know if there are ways I can improve my code, or ways to make it more efficient and clear.
Hi, 👏 congrats for completing the challenge
For the h1
text, I think you should try font-size
to 20px
or 21px
. And for the p
, try to remove alpha (transparency).
Everything is nice! 🤘
@snowsneakers
Submitted
Very new to React so I wanted to do something less difficult and improve my familiarity
Hi, 👏 congrats for completing the challenge
For the rounded on the white card, I think you should try rounded-2xl
to look similar to the design. and add some shadow
maybe.
Everything is nice! 🤘
Marked as helpful