Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Dolapo 820

    @nofeesahdee

    Posted

    Your solution looks good beside the provided design, but a tiny colour change can be made to the border. Accessibility is great as well. Well done

    1
  • Kevin 160

    @Kevin-Kigotho

    Submitted

    Please give any feedback, I will highly appreciate it.

    QR-Code-component-main

    #accessibility

    2

    Dolapo 820

    @nofeesahdee

    Posted

    Great job Kevin, For the accessibility, instead of using div, try use semantic html5 such as main

    Marked as helpful

    1
  • Dolapo 820

    @nofeesahdee

    Posted

    You have done well saajeves

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi paul, great job.

    Here are adjustments you can make to improve accessibility;

    • Use a semantic tag such as <header> <main> to put your contents in landmark
    • Include the contents of your web page aside the <header> and <footer> into the <main> tag
    • Always use an alt text in your images.

    Goodluck

    Marked as helpful

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Aphrysof, great work

    However, to improve your accessibility, always include an alt text into your image. <img src = "image.png" alt = "image">

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Nathan, you’ve done a great job. However, you can improve on accessibility by:

    Using <main> tags instead of <div> Format the <img> url properly

    Marked as helpful

    1
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Francisco, Great work 😊, here’s a little feedback to improve accessibility.

    Use ‘<main>’ tag to include all the other tags instead of <div>, basically what I am saying is, try as much as you can to use html5 semantics where necessary

    Marked as helpful

    1
  • @LeoCaprile

    Submitted

    Hi Guys! I made this in like 8 hours, in my spare time. I been learning React for like one month, can you give me feed back about the folder arquitecture that I used. Or if i used hooks wrong etc. Thanks!

    Dolapo 820

    @nofeesahdee

    Posted

    Hi Matias, you’ve done a great job. However, endeavor to include alt text into your images to improve accessibility.

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Keep at it, it gets easier

    1
  • @manishasamanta

    Submitted

    I faced problems to place the elements properly. is my approach correct? or I should change the way for positioning ? And please let me know about my mistakes 🙏🙏🙏. Thanks 😊.

    Dolapo 820

    @nofeesahdee

    Posted

    Hi Manisha, great work.

    Here are a few suggestions to help improve your accessibility and HTML issues;

    • Please check your image format <img src = "./images/....> not `<.\image...>
    • Ensure to wrap your body into a <main> tag.
    • Use semantic HTML tags as much as possible to replace divs

    Keep it up, it gets better.

    Marked as helpful

    0
  • @IllaMelo

    Submitted

    Hello everyone!!! This is my response to the challenge and I would like to hear the feedback because I'm still a noob.

    Dolapo 820

    @nofeesahdee

    Posted

    Great work camila, you seem not to have any issues whatsoever. However, you probably forgot to change the background color.

    Keep it up

    Marked as helpful

    1
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Lucas, great work. To tackle the accessibility issue, you should wrap the body in a <main> tag

    Marked as helpful

    0
  • @OlafZiorko

    Submitted

    Goodevening or goodmorning whetever you are. Starting jurney with frontend technologies.If you can leavea comment and add something usefull please do it. Thanks to all of you.

    Dolapo 820

    @nofeesahdee

    Posted

    Hi Olaf, great job. However, you should include alt text into your image to improve accessibility

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Vidottizz,

    Great job, here are few changes you might want to make to improve your code

    1. Always add alt text to your images to improve accessibility
    2. Ensure to use html5 semantics such as <header><main> this will help put your codes into landmarks
    0
  • Dolapo 820

    @nofeesahdee

    Posted

    would refactor it

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Udo, great job

    You've done well, however, since you use the <main> tag, using a class of main isn't necessary

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    You are welcome

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi Maria great job, Here are few observations I think you might find helpful

    1. Always include alt text in your image to improve accessibility
    2. Your input is overflowing its container, you might want to add some padding to that
    3. You can not use id in multiple places, use class instead
    4. Add circle to the fab fa-circle-facebook to include circle in your icon
    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Hi, I think you should try as much to center your container.

    use: body{ display:flex; justify-content:center; align-items:center; min-height:100vh; }

    Marked as helpful

    0
  • Dolapo 820

    @nofeesahdee

    Posted

    Thank you so much for the reply, I have been having issues with the image, didnt know there was a different image for mobile.

    Your reply meant so much to me

    1