Jean• 335
@JeanMieses
Submitted
Feel free to give me any feedback.
P
Patrick
@palgramming
All comments
- Matias• 330
@mmc1999
Submitted
please feedback
When the user selects a region from the drop-down the list does not show an option has been selected. The countries seem to update but there is no conformation that the user selected the correct region
Marked as helpful
0 - Sina gholami• 10
@sinaGh-cyber
Submitted
Hello everyone, it's my first experience in coding a CSS project on my own. I will be happy to have your guide. In the style-guide.md file the font size Is 16, but I had to use a smaller font size to code this design. Is it a misunderstanding of style-guide.md content?
you should change you body background styles to this
background: url('./images/pattern-background-desktop.svg'); background-color: var(--Pale-blue); background-size: 100vw 40vh; background-repeat: no-repeat;Marked as helpful
1 - Amon• 2,560
@A-amon
Submitted
Any feedback is welcome~
you should change the background-size on the body tag from
100%to '100% 40%or100vw 40vh`Marked as helpful
0 - Adekola Thanni• 590
@AdekolaThanni
Submitted
Any feedback would be appreciated :)
you should limit the use of the
.key so the user cannot enter a number like this1.2.3.4.5.6.7.8.90 - Asim• 265
@asim-ali5514
Submitted
Please leave any feedback as this was my first fully responsive website! I also had a bit a fun with the animations from framer motion and I hope you guys like them!
The main thing in you nav that is no state change for the user to know what page they are on. Some how you need to highlight to the user what page is currently selected
0 @letyoursoulglo
Submitted
Any feedback is appreciated, I am still learning how to implement media queries so any tips would also be appreciated.
you should change the background size on your body tag from
containto100vw 40vhMarked as helpful
0- Daniel Haro• 50
@o0oDanielHaroo0o
Submitted
I ran into a problem with the border-radius. Starting at 1055px screen width it seems to flatten out and ends up looking like a regular box. I can't seem to find the source of this issue. Any help would be appreciated!
well you you need to put the border raidus on the corners of your cards that need them
Put this on your orange card
border-radius: 20px 0 0 20px;then look at how the dark cyan card compares to the results on the orangethe key is you have to transition the border radius corners on the cards depending if it is the mobile or desktop layouts
Marked as helpful
1 - Tamera• 110
@tlbodrick
Submitted
For some reason, the cards resize randomly when changing the window size and I can't figure out why.
you need to put a controlled height on your card container you currently had 100vh but I put 60vh on it in web dev tools and then one each of your individual cards put a height of 100% on each of them
thank should get you close
Marked as helpful
0 - Jeff• 80
@jcombs0929
Submitted
I decided to use svgs for the images, and they can be confusing. Please let me know if I utilized these incorrectly. Thank you!
well just attach the SVG main background to the body tag in your css you do not need all the extra effort and code to when you can use use this https://www.w3schools.com/cssref/css3_pr_background.asp
Marked as helpful
0 - Jhilaryt Garcia• 10
@Jhilaryt
Submitted
Hey, if you have any feedback please do not hesitate in share it :-)
maybe start by attaching the main background to the body tag in the css and not using a img tag to insert it in the page https://www.w3schools.com/cssref/css3_pr_background.asp
0 @shrewdmind
Submitted
Modified Version.
I made some changes in my code to achieve a better result.
Please feel free to drop any reviews or advice on how I could've achieved a much better result.
Thank you! :)
Looks Nice. Good Job 🌟🌟🌟🌟🌟
Marked as helpful
0- evilhare• 20
@evilhare
Submitted
Any feedback to improve my coding? I don't really know what to ask. Feel free to suggest or recommend anything to improve my css skill. I'm just a newbie dreaming to master css. Anything will be appreciated.
Nice job with the background placement and keeping the card centered in the window. You ended up with a really nice solution. Great Job!! ⭐⭐⭐⭐⭐
Marked as helpful
0 - El-karece Asiedu• 20
@KareceA
Submitted
how can I make this more interactive with javascript
You should add
background-repeat: no-repeat; background-size: 100vw 40vh;to the background image on your body tag
0 - Haziq• 320
@zyq-m
Submitted
Any suggestion please let me know.
you should change the
background-sizeon your body tag fromcontainto100vw 40vh0 - Sravan• 220
@SravanSTG
Submitted
Any feedback on how to improve this is appreciated.
Thank You! 🙂
You need to change your media query width from
900pxto100pxso when your social media pop up opens it does not go off screenMarked as helpful
0 - Brian Carlo Birondo• 320
@Briancarlo24
Submitted
How was my solution?
On your body tag you should change your background size from
containto100vw 40vhMarked as helpful
0 - Nguyen Duy• 245
@koalalikecode
Submitted
This is a wonderful project for practicing your CSS grid skills. I appreciate any suggestions or advice.
Not saying this is a perfect solution to your challenge but you should play with this setting to see what is happening On your
.containerChangegrid-template: 284px 264px/ 258px 258px 258px 258px;To thisgrid-template: 1fr 1fr/ 1fr 1fr 1fr 1fr;Then add thismargin: 2em;Marked as helpful
0 - Sebastian• 770
@Sebastian-1406
Submitted
Cualquier comentario para construir se agradecer... :)
The
Daniel Cliffordtext goes behind the apostrophe svg in the mobile layout you should change the z-index on a element to fix this0 - Thiago Araujo• 210
@Thiago-a1
Submitted
Todo feedback é bem vindo, Feedbacks is welcome.
you should change your
background-size: 100vw auto;tobackground-size: 100vw 40vh;Marked as helpful
0 - José Figueroa• 300
@josefigueroa
Submitted
Any feedback is welcome!
- your header links do not have a hover state
- your email and phone in the footer are not links
href="tel:#########"andhref:"mailto:[email protected]" - you social links in the footer have no hover state
- you email signup has no validation
0 - Ravi Pratap Singh• 110
@cyberspatial
Submitted
Your constructive criticism will help me to improve my skills.
you should change the
background-sizeon your body tag from100%to100vw 40vhMarked as helpful
1 - Mate Giorbelidze• 100
@mateiahacks
Submitted
I know that I didn't treat good with fonts, and if you give me some tips about it and other things I would be thankful.
you should change you background-size on the body tag from
containto100vw 40vhMarked as helpful
0 - Achraf Elmouhib• 460
@NightClover-code
Submitted
Hey everyone 👋
I'm back after a while on front end mentor challenges, this one was pretty fun to make. The hardest thing to implement was probably the toggle button, but nothing too crazy.
I built this using Next.js and Typescript, as well as scss for styling.
Any feedback is most welcome. Enjoy your coding journey 🚀
you need to limit the use of the
.so a user cannot enter a number like this1.2.3.4.5.6.7.8.90
