Ricky
@rickyxyzAll comments
- @Cyrilange@rickyxyz
Cool React code.
For the CSS, I usually sees people use
rem
instead ofpx
for sizing. This article might be helpful PX or REM in CSS? Just Use REMCheers 🍻
Marked as helpful - @Cyrilange@rickyxyz
Fellow beginner here, so take this with a grain of salt 🧂.
I think this could be helpful for you BEM naming convention, since CSS names can get confusing quickly.
Cheers 🍻
Marked as helpful - @Renukta-21@rickyxyz
I'm also a beginner, so take this with a grain of salt 🧂.
I think your HTML structure is odd.
Take for example your 3
botCard
cards, they have no containerdiv
to unify them. This could a problem when you have more than 3 cards, for example you would need to re-style the grid layout if there are 4 cards. I think it would be better if thebotCard
cards are contained in a div withgrid
orflex
layout.Also you might want to look into semantic HTML5 guide.
Cheers 🍻
- @Evergardenx@rickyxyz
Fellow beginner here.
I think this could be helpful px or rem in css, since I usually see a lot of people use
rem
instead ofpx
.Cheers 🍻
Marked as helpful - @talhaasre@rickyxyz
I'm a beginner myself, so you might want to take this with a grain of salt 🧂.
Maybe you could try making responsive font size and styling the elements using
rem
based on the responsive font size. Also, just as a suggestion, you might want to look at the most common screen size being used right now, so you can determine how small or how large of a screen you should accomodate.Cheers 🍻.
- @MrDevM@rickyxyz
I'm also a beginner, so you might want to take this with a grain of salt 🧂.
Just a suggestion, I think this article could be helpful BEM naming convention.
Cheers 🍻.
Marked as helpful - @anusha-fatima@rickyxyz
Just a small suggestion for the number input, maybe hide the default up and down arrow in the input. Since in firefox the arrow is always visible.
This could be helpful. W3S Hide Arrows From Input Number
Cheers 🍻
Marked as helpful