Skip to content
OverviewSolutions
23
Comments
6
Ron Paolo Toyhacao
@rontoyhacao

All comments

  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Hello Paweł!

    Nice to hear that you've had the challenge easy and you did great! Upon seeing your work I see that your main section is positioned at the top and not at the center. Since you already have your body tag at flex, one last thingg you can add is height: 100vh to have it centered. That's all and happy codingg.

  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Hello Karishma Garg!

    You did veryy well on this challenge, great job! One thing I noticed is that the button wasn't interactive as it was supposed to. One way to solve this is by using the cursor: pointer in css. This helps the user to identify buttons. Using hover pseudo-class also helps.

    I also see that you were not able to implement the email validation. One way to do it is to use Regular Expressions in JavaScript.

    Marked as helpful
  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Hello John Rey,

    About your typography concern, it is highly encouraged that you use rems instead of pixels because pixels are absolute units, meaning they are fixed. Once the client sets to a different font size on the browser's settings, pixels simply won't follow. Also I find that using clamp() on the font size is a great idea, maybe I could use that technique as well. Btw great work, happy coding. :))

  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Hello, everything works great. The only thing that bothers me is the checkbox, i can't access it when I press tab but overall it's functional. good work :))

  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Your work looks great and neat! Regarding with css, I highly suggest that you use sass since it works the same with what you did, separating styles by parts but in sass, it compiles them into a single css file so your stylesheet would be organized. if you have no idea about it I highly recommend you to use it, everyone's using it. You did a great job in this challenge. :))

  • Ron Paolo Toyhacao•165
    @rontoyhacao

    Love it! The visual looks good and exact to the design. I wish I could make a whole landing page like this. It's a great work.