Skip to content
OverviewSolutions
13
Comments
6
Benjamin Thorpe
@sparrowsl

All comments

  • Benjamin Thorpe•280
    @sparrowsl

    This is just too amazing, makes me want to do it now. I have no words to say here :)

    I only found that the spacing on the right side is not consistent with the left (on desktop) Everything else if just fire and amazing

  • Benjamin Thorpe•280
    @sparrowsl

    Cool code, I love how you tackle the javascript part ;)

    Few suggestions:

    • the radio button between each other spacing is too much (as per design)
    • try removing the ...onclick="submitRating()"... from the HTML (use javascript to get the button and add an event listener)
    • start practicing how to use the DOM

    Nice code,

    Marked as helpful
  • Benjamin Thorpe•280
    @sparrowsl

    This is just awesome and beautiful. The only error I found was that the twitter link is not working.

    everything else works great.

    You have made me want to do this as my next one

  • Benjamin Thorpe•280
    @sparrowsl

    Wow, awesome job, I have a question after I read the JS code on github.

    can you explain line 10 to 14 that contains this code: ratings.forEach(rate => rate.classList.remove('selected'))

    It looks redundant for looping over the rating array inside each rate. Maybe it could work if you bring it outside.

    let me know your thoughts on this.

  • Benjamin Thorpe•280
    @sparrowsl

    I have a question and a doubt on the functionality.

    It allows for multiple choosing (is that suppose to happen??) eg: I can choose all the options

    but the last option will always be the rating stored. overall everything works well and cool

  • Benjamin Thorpe•280
    @sparrowsl

    Hi Kishan, nice work really, few points:

    • use the font provided in the style-guide file
    • also try to use labels for each form input

    eg: <label for="email"> <input type="email" id="email"> </label>

    Good job

    Marked as helpful