@timilehin223
Submitted
Is there anything I could have done better?
Mustapha Al-Amin Oluwatimmilehin
@timilehin223
All comments
@timilehin223
Posted
I have issues with the responsiveness. The two columns of the grid container are not responsive. Only the second column is. What can I do about this?
0- uwaoma cyrus• 110
@CyCodez
Submitted
@timilehin223
Posted
There are a few issues that need to be addressed to meet the requirements specified in the style-guide.md file. The required font for the project is missing, and it needs to be imported from Google Fonts in the CSS file.
Furthermore, there is a discrepancy in the text color for the .text class, which needs to be corrected to match the style guide.
Regarding the background color, the body should be blue, but the .outerdiv class has been assigned this color instead. To adhere to the style guide, the background color should be applied to the body element.
Moreover, it appears that the current structure involves an unnecessary .outerdiv element, which contains the container for the card that holds the QR code and text. Since there is only one container involved, it would be simpler to place the card directly inside the container element, removing the .outerdiv.
Finally, it's recommended to consider increasing the width of the container element to ensure proper alignment and layout for the card.
To rectify these issues and achieve compliance with the style guide, follow these steps:
- Check the style-guide.md file to identify the required font.
- Visit the Google Fonts webpage and import the font into the CSS file.
- Correct the text color for the .text class to match the style guide.
- Apply the blue background color to the body element.
- Remove the unnecessary .outerdiv element and place the card directly inside the container element.
- Adjust the width of the container element to ensure an appropriate layout.
Marked as helpful
0 - mav• 90
@xmavv
Submitted
Hey, as it's my first solution, I have 2 questions that sometimes blow my mind. When to use vw and vh, when %, and when px. For this site I did px, because I don''t want my card to change size while, width is changing. It is correct? Second question is when to use margin and when padding? Do they have their own rules?
@timilehin223
Posted
I have the same questions as you, however I think that using px is right in this challenge as the size of the card stays the same. I believe % is for a responsive design.
1
