[2nd] Sign-up Form w/ CSS grid, JS - Newbie

Community feedback

• 

  Amon•2,560

  @A-amon

  Posted almost 4 years ago

  Hello! Looks great~ It's responsive too.

  I have a few suggestions for you 😀:

  • Why do you have wrap a line inside h1 with span tag?🤔 You can try using br tag to break the line of the same sentence. (Don't abuse it tho! Check out https://forum.freecodecamp.org/t/should-you-ever-use-the-br-tag/440252/2 for how to use it semantically.)

  • Try to not set styles directly in JS if possible. Add/remove or toggle class instead. E.g. Adding .error class to show error-related styling.

  • Instead of having an unused empty label, set the aria-label attribute on input element. (Doing this allows you to remove the label element)

  • The alt text for your error icon might not be appropriate 🤔, because imagine if the screen reader reads out "Exclamation" or something else to users. Maybe, "Warning", etc. would be better. Or if you wish to hide it, just leave the alt empty. Check this out: https://dev.to/nadiarasul/do-icons-need-alt-attributes-5g52

  14

  Marked as helpful
• 

  

  Chamu•13,860

  @ChamuMutezva

  Posted almost 4 years ago

  Nice work, the validation can be improved such that when correct data is entered whilst typing the error disappears. See this solution that impressed me this week solution

  • you do not need to resubmit your solution when you make changes to your code. As long as you update you repository then everything will be ok, you can generate another report if you want to see if some errors on this site has been cleared

  03

  Marked as helpful