3-column preview card component: Mobile first using Flex

Community feedback

• 

  Raza Abbas•770

  @RazaAbbas62

  Posted over 1 year ago

  Hi, For button you are setting its color on button a selector, while for hover you are just using button, so due to less specificity of button as compared to buutton a u need to add important tag.

  For the width of main, you are using width two times in the same selector , that's why it is causing problem,

  And flex-direction:row is working fine without important tag.

  I hope this will help.

  Enjoy Coding:)

  20

  Marked as helpful
• 

  

  Emmilie Estabillo•5,600

  @emestabillo

  Posted over 1 year ago

  Hey @DanielleLensly, great job on completing your project! Some recommendations:

  CSS:

  • add a reset to your stylesheet
  • use relative units such as rem instead of px
  • lines 116 and 122 are identical as mentioned previously. So are lines 80 and 141.
  • For the width of the cards:
    1. set amax-width in rem on the main container and
    2. remove all widths and max-widths on the cards. Use padding to keep the content from touching the gutter
  • For centering the component on the page:
    1. Remove position: absolute from main and position: fixed from attribution. You don’t even need static since that’s the default
    2. use flex (or grid) on the body:

  body {
      min-height: 100vh;
      display: flex;
    
      flex-direction: column;
    
      align-items: center;
    
      justify-content: center;
  }
  

  HTML:

  • a tags redirect users to another page/section of a site, which is what we need here. Instead of buttons which perform an action (ex. submitting information or hiding/showing divs)
  • div class="main” can be replaced by <main>
  • Write your markup as if you are writing a word document. There should only be one h1 (main heading) on a page. There’s no clear heading in the design, but you can add one with the sr-only class. Check out this article and here's another one for the headings.

  Hope this helps!

  10