@brasspetals
Posted
Yet again an incredible job! π The keyboard accessibility is awesome, and the custom theme picker is so cool! I also really appreciate how helpful and packed full of resouces your README is!
π΅οΈββοΈ I did some serious hunting and can only come up with two minor suggestions.
- A "reset to defaults" type of button would be nice on the theme settings modal. (Excellent job on the modal focus trap, btw).
- If
calc__display-value--previous
is emptycalc__display-value--current
shifts upward. I think design wise, it'd be best if the current number always kept the same position.
@brasspetals Thank you Anna for great feedback! Not gonna lie I forgot about the reset button for theme. It really would be pain in the neck to change them all after taking a fun experimenting different colors. π There is not much room for third button on mobile, not sure how to approach this. What would you say for having 3 icons on mobile like reset icon, save icon, close icon and then on 480px or tablet 769px it would be button for each reset and save and then icon for close like it is now.
UPDATE: Reset button has been added to the project. π
UPDATE2: Fixed a bug where calc__display-value--current
shifts upward when --previous
was empty.
@brasspetals
Posted
@tediko Just checked it out - the reset functionality is great! The icons for mobile was an excellent idea, and executed really well! π The only small thing I noticed upon reset is that the custom theme resets, but if you open up the color picker, the colors are still set to the custom colors before reset. Maybe this is intentional?
Display bug is also all fixed, making the calculator even more "seamless". π―π
@brasspetals It wasn't intentional π It is fixed now. Thank you for your feedback Anna!