Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS QR Code Component v2

@Paul21777

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@ccreusat

Posted

Hello !

Nice job! Seems ok to me :)

Some improvements :

  • You can replace your <div class="title"> by a <h1>, this will fix your acc. issue
  • Check the design if you can have a bigger line-height for the text.
  • You could change how to handle margin on title and description as well: -- For instance, you can remove all margin on .title and .description -- Add a padding: 24px on your .text -- Add this to your code :
.title + .description {
    margin-top: 24px;
}

Marked as helpful

0

@Paul21777

Posted

@ccreusat Hello !

I have done everything that you suggested. Have to fix things so that it exactly correspond to the design

Thanks for the feedback !

1
P

@ccreusat

Posted

@Paul21777 Looks awesome man ! :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord