Skip to content
OverviewSolutions
32
Comments
95

Clément Creusat

@ccreusatFrance1,655 points

Senior Front-End Developer - Web & Stack React

Latest solutions

View more solutions

Latest comments

  • Clément Creusat•1,655
    @ccreusat

    Hi ! Nice job!

    To set the modal backdrop (background), you can add a React.Fragment in your file Bamboo.jsx to wrap your modal className="modal-oculto ..." and add a new div in position:fixed right after your modal.

    I did something like this for my challenge :

    .modal-backdrop {
position: fixed;
inset: 0;
z-index: 1;
background-color: rgb(0 0 0 / 50%);
}

    Ejemplo :

    {mostrarModal && (
 <div className='modal-oculto ...'>...</div>
 <div className="modal-backdrop"></div>
)}

    Hope my comment helps :)

    Marked as helpful
  • Clément Creusat•1,655
    @ccreusat

    Hello !

    • Everything @besttlookk said is super helpful!

    I will add some stuffs to improve :

    • reply to a comment should open the right input below the comment, not in the same view used to write a comment
    • I'm not sure about the sticky position for the current user input. It's a bit weird on responsive.
    • Maybe put a fixed width to the upvote/downvote component. Behavior is a little weird
    • On .comments-container I would go for a max-width rather than putting a width. It behaves better

    Hope this helps !! Keep coding ! =)

    Marked as helpful
  • Clément Creusat•1,655
    @ccreusat

    Hello IHSAN!

    It seems that the app.js is not working or loaded. I can't switch between timeframes (daily, weekly, monthly)

    If you don't have access to the design files (sketch or figma), I would suggest to install Figma. Use the designs provided in the folder and put the desktop version inside a Figma's file. Then do a screenshot of your solution and add it to the same Figma's file. Put your solution above the design with the Layer option to 50% opacity. You will be able to compare what to adjust or not (like fonts, ...)

    One improvement could be going into responsive view earlier in your breakpoint setting. It's a little be smashed between 440px until 800px.

    For centering your solution, take a look at link

    Enjoy coding!

  • Clément Creusat•1,655
    @ccreusat

    Hi ! Nice challenge done !

    You should fix to things :

    • line-height of your <label> numbers (seems to not be centered)

    check your code because you are putting align-items: center on the labels but not using flex or inline-flex (I saw display:inline-block)

    • Text of the Thanks screen should be centered. I did the same mistake : display:flex and align/justify: center won't centered the text.

    Hope this helps & enjoy coding!

  • Clément Creusat•1,655
    @ccreusat

    Hello !

    This is a really good work ! It's 99% perfect ;-)

    One thing I noticed tho.. When you submit without selecting a value, there is a strange thing happening. You should add a verification IF a value is selected before submitting. IF NOT, display an error or an alert('') explaining user has to choose one value :)

    Enjoy coding!

    Marked as helpful
  • Clément Creusat•1,655
    @ccreusat

    Hi! Nice job! It's pretty closed to the design :)

    I would suggest few things as improvements:

    • not setting height on your .card but adding a gap: 2rem (~) on your card-ranking
    • width of .card should be max. 412px on desktop
    • submit button has ~30px border-radius; not 15px :)
    • add a bigger line-height on your texts.

    hope this helps. enjoy coding!

View more comments