@DavidXploidz
Submitted
What did you find difficult while building the project? How would you manipulate the background color when a modal is active?
Looking to hire developers?
@ccreusat
@DavidXploidz
Submitted
What did you find difficult while building the project? How would you manipulate the background color when a modal is active?
@ccreusat
Posted
Hi ! Nice job!
To set the modal backdrop (background), you can add a React.Fragment in your file Bamboo.jsx
to wrap your modal className="modal-oculto ..."
and add a new div in position:fixed right after your modal.
I did something like this for my challenge :
.modal-backdrop {
position: fixed;
inset: 0;
z-index: 1;
background-color: rgb(0 0 0 / 50%);
}
Ejemplo :
{mostrarModal && (
<div className='modal-oculto ...'>...</div>
<div className="modal-backdrop"></div>
)}
Hope my comment helps :)
Marked as helpful
@HeinZarNe
Submitted
@ccreusat
Posted
Hello !
I will add some stuffs to improve :
sticky
position for the current user input. It's a bit weird on responsive..comments-container
I would go for a max-width
rather than putting a width
. It behaves betterHope this helps !! Keep coding ! =)
Marked as helpful
@itb1825
Submitted
I'm grateful if someone tell me how can I improve my skills.
@ccreusat
Posted
Hello IHSAN!
It seems that the app.js
is not working or loaded. I can't switch between timeframes (daily, weekly, monthly)
If you don't have access to the design files (sketch or figma), I would suggest to install Figma. Use the designs provided in the folder and put the desktop version inside a Figma's file. Then do a screenshot of your solution and add it to the same Figma's file. Put your solution above the design with the Layer option to 50% opacity. You will be able to compare what to adjust or not (like fonts, ...)
One improvement could be going into responsive view earlier in your breakpoint setting. It's a little be smashed between 440px until 800px.
For centering your solution, take a look at link
Enjoy coding!
@bilwagutthi
Submitted
No particular question but any recommendations to improve is welcome :D
@ccreusat
Posted
Hi ! Nice challenge done !
You should fix to things :
<label>
numbers (seems to not be centered)Hope this helps & enjoy coding!
@j-hutchison
Submitted
@ccreusat
Posted
Hello !
This is a really good work ! It's 99% perfect ;-)
One thing I noticed tho.. When you submit without selecting a value, there is a strange thing happening. You should add a verification IF a value is selected before submitting. IF NOT, display an error or an alert('') explaining user has to choose one value :)
Enjoy coding!
Marked as helpful
Hello everyone!
please let me know how I did, and any feedback is welcome, I would also like you to share any resources to learn how to manipulate the DOM
Thank you very much!
@ccreusat
Posted
Hi! Nice job! It's pretty closed to the design :)
I would suggest few things as improvements:
.card
but adding a gap: 2rem (~) on your card-ranking
.card
should be max. 412px
on desktophope this helps. enjoy coding!
I am a beginner in web development but I have tried my best to comping up with a solution for this challenge, it has a lot of bugs but somehow it still works. Feel free to provide some insights on my solution.
@ccreusat
Posted
Hello ! Good job :)
It looks nice but you can improve your solution if you wants :
.container
, make it with max-width: 350px
and remove height so it could breathe :)max-width: 100%
on your main image is a better practice than width: 90%<div class="active">
element inside your <div class="image">
and modify the CSS to :.active {
cursor: pointer;
background-color: hsl(178, 100%, 50%,50%);
border-radius: 5%;
text-align: center;
position: absolute;
inset: 0;
align-items: center;
justify-content: center;
display: none;
}
.active
element could be a link and leads to another page (maybe change the div to a <a>)And when hovering it, change display:none
by display:flex
> .Image:hover .active
Hope it helps and Enjoy Coding!
@MarcusTuliusCiceron
Submitted
This is my first react app, it was really comfuse at fisrt so I decided to scrap all the the code and started again from scratch, I think the structure is much better and easier to work with on this second attempt.
I noticed I never used componentdidmount and componentdidunmount methods, is this ok to not use those methods ?
Also my react component page is holding a lot of infos through its state, I didn't find any other way to be able to reuse info from one subcomponent to another.
SCSS is defintely not that clean.
If you find anything not working properly or if you have any suggestion feel free to give a feedback.
@ccreusat
Posted
Hello! Great job, its working really well :)
Some advices if you want to improve your solution :
transform-origin: 0
. I think the cross will have a better UI this way.max-width: 730px
, margin: 0 auto
on desktop and margin: 0 24px
on mobile. Let it breathe :) It will look more fluidThen:
About the code : it's really great. Just two thing :
class ModalPledge extends React.Component {}
as a new file (ModalPledge.js
) and Import it in your app.js. It will look something like this :
import ModalPledge from "./ModalPledge"
<ModalPledge props={...}/>
, pass the props you needs, etc...And last thing, React is supposed to stop support for ES6 JS CLASS. Take a look at React Hooks Link
Hope it will help and Enjoy Coding!
Marked as helpful
@Suprefuner
Submitted
Hi All,
Please check my solution here.
@ccreusat
Posted
Hi ! Good job there :)
As @isprutfromua said, fix your html and a11y issues. Take care of his advices too.
For the positioning on your component, you are using Flex on <body>
with flex-direction:column
. It lacks of centering because when using flex-direction:column
, the "axis" changed.
align-items: center
is not positioning on the Y axis but on the X axis. So to fix your design, add justify-content: center;
to center your component on the Y axis
Hope it will help :)
Enjoy coding!
Marked as helpful
@turtlecrab
Submitted
My first project here! This site is awesome! I'm in my n-th attempt to learn frontend stuff and this community is just perfect for that!
So problems/questions I got during this project:
img
inside a button
? I suspect the way I did is not great for accessibility.position: absolute
with static
, but couldn't find proper flexbox parameters so it would stick to the bottom or scroll when the advice is long. Probably I shouldn't have positioned it absolutely in the desktop view(and should've started with mobile-first approach).@ccreusat
Posted
Hello and Nice job!
Hope it will help :
position:absolute
and add a gap:4rem
(more or less) on the <body>
. I think for the demo of this challenge, would be enough :)Enjoy coding!
Marked as helpful
@Paul21777
Submitted
@ccreusat
Posted
Hello !
Nice job! Seems ok to me :)
Some improvements :
<div class="title">
by a <h1>
, this will fix your acc. issue.title + .description {
margin-top: 24px;
}
Marked as helpful
@glauberbandeira
Submitted
@ccreusat
Posted
Hi ! You almost got it :)
You could :
padding: 0.5rem 1.2rem;
color: hsl(25, 97%, 53%);
font-size: 1.4rem;
border-radius: 22px;
background-color: hsl(213, 19%, 18%);
Marked as helpful
@rebeccaaaaaaaaaaa
Submitted
@ccreusat
Posted
Hello ! Glad you submitted this challenge!!
Some things you could improve:
Hope this will help :)
Marked as helpful
@charlottesaidi
Submitted
@ccreusat
Posted
Hello ! Nice job!
I see few points of improvements:
@newbpydev
Submitted
This is my solution to the Profile card component challenge. It is a simple card that shows the image, name, age, city, and stats of a user. I practiced by using the ::before and ::after pseudo-elements.
@ccreusat
Posted
Hi !!
nice job!
Consider using a <ul> <li> list for the user's stats. It looks better to me
Marked as helpful
@Ivuska
Submitted
Hi from Czechia :)
I have updated my solution with the recommendations from the community.
Happy coding weekend!
@ccreusat
Posted
Hi ! Nice job, you completed it and is good!
Really interesting to read your notes about your experience on this challenge. That's definitely a good tip!
I would suggest to add link on :
<span>
with a <a>
tag:)
Marked as helpful
@fraserwat
Submitted
Tried out a new methodology for this, CUBE CSS (there's a good walkthrough of the rationale and a sample web page here). Really really liked this, it's quite utility focused but you don't end up with having to remember 1,000 utilities and make your HTML look incomprehensible like you do with Tailwind (but maybe I'm just using Tailwind wrong!). I feel like my CSS is less repetitive and I feel like I wrote less of it than usual (although that might be due to the relative lack of complexity in the project, and would be difficult to measure given the amt of auto generated classes in the config).
Still going to take a bit of getting used to but I think I'm going to bring this more into my CSS more generally (it works really nicely with SASS).
Towards the end I think I got a bit hacky and there's probably a better way I could have done the layout for Desktop than making the hero image and the stats list position: absolute
... Any ideas here?
@ccreusat
Posted
Hi! Nice job. Your layout is perfect! Wasn't quite satisfied with mine and seeing you, blew my mind ^^
Just something you forgot : the blur pattern behind jeremy's image! :)
Marked as helpful
@Infect3d
Submitted
On mobile version container won't stay at the center of the screen. Could You help me fix this ?
@ccreusat
Posted
Hello ! Great job, you nailed it :)
To center an element in the viewport, I would suggest better day than using margin-top/padding-top with %;
Take a look at this link : here
Enjoy!
Marked as helpful
@ankithapai
Submitted
i dont know how to use github well as of now hence i cant host it
@ccreusat
Posted
Hello !
Your project seems to be on Github. First of all, sounds good :) Then you can create a free account on Vercel or Netlify to host your project.
I use Vercel, it's super easy. Just connect your github account within Vercel and then import your project. Deploy it and share your live project ! :)
Marked as helpful
@aropsta
Submitted
Any suggestions or questions are welcome! :smile:
@ccreusat
Posted
Nice challenge ! Interesting to see the use of React context with Class components.
I would suggest to use .map()
method to render your <Card>
component instead of selecting all your item like this :
let work = inputData[0];
let play = inputData[1];
let study = inputData[2];
let exercise = inputData[3];
let social = inputData[4];
let selfCare = inputData[5];
You could do
{ inputData.map((item, index) => <Card key={index} data={item}></Card>}
index
could be replace with ID (and it's a better practice)
example : key={item.id}
Hope this helps :)
Marked as helpful
@aboAbassAlshaege
Submitted
@ccreusat
Posted
Welcome ! Almost perfect. The first text should be in a heading tag or strong tag. The second text should be in your <p> tag.
@arthurparaschiv
Submitted
@ccreusat
Posted
Perfect ! Welcome to Frontend mentor :)
@adram3l3ch
Submitted
Feedbacks will be appreciated :)
@ccreusat
Posted
Hi ! Works like a charm !
Just one thing : I can't reply to the first comment and this should work, right?! Will take a look at your code to compare your React code with mine! Thank you and keep going!
Marked as helpful
@xZAYEDx
Submitted
Open for all feedbacks 😁
@ccreusat
Posted
Hello ! Really really good challenge! You did it !
One suggestion about center the card component, check the first example of this page on developer mozilla : link
Marked as helpful