@mattstuddert
Posted
Nice work, Patrick, and congrats on submitting your first solution! Here are a few pointers after taking a look at your code:
- You're using heading elements when I'd say paragraphs would be better suited. For example, I'd say the "Gain access to our full library..." text is a paragraph, not a
h3
. - You're using HTML5 structural elements which is great. But I would say you could use the
article
andsection
elements better. Anarticle
is typically used to contain distinct content that could live independently from the rest of the content on the site/page. Good examples of this would be blog posts, articles, and forum posts. Asection
is typically used to wrap a larger grouping of themed content. For example, the whole Slack sign up area below these comments would be considered asection
. For smaller groupings of content I'd then usediv
elements. So for this challenge, I'd say the whole thing is asection
and the inner areas are justdiv
elements. - I'd use a
ul
for the list of benefits/features as opposed tobr
tags. - The whole component could also have its
width
restricted so that it isn't quite so wide.
I hope these tips help. Let me know if you have any questions! 👍