Amir Jacobs• 165
@Amir-Jacobs
Posted
I love the fact that you used "preconnect" on the google font.
There's are a few things I'd do differently:
- I'd avoid using
position: relativeandposition: absoluteif I can. - I would change
width: x%towidth: 100%; max-width: x%as this helps with responsive design ("x" being the width you want). - something is making your
bodytoo tall -- it probably has something to do with your use ofposition, so I'd useoverflow: hiddenon the body to make it not scrollable. - I would put the stylesheet
<link>elements after the title and thescriptelements at the bottom of your<body>element. - I'd remove the
.attributestyling and move it to your stylesheet. - I'd add a subtle transition to your buttons when hovering by using
transition: 0.3s ease all. - I'd put the
<img>element in the<div class="container">too.
You're doing amazing so far. Keep it on! :)
1
Mike Schmidt• 90
@Schmidt217
Posted
@Amir-Jacobs
Thank you for your suggestions! I tried them out in my VSCode and it seems to have helped. Thanks for the feedback!
0
