Huddle Landing Page created for #TOR100 project: 100 days of code

@rfilenko

Hi Roman, thanks for taking the time to help out!

• I believe the multiple selectors issue you are referring to comes from the processing of my SCSS files to CSS due to the nested nature of the SASS language, correct me if I'm wrong or if I misunderstand.
• Thanks, I have wrapped the logo in an a-tag now.
• Images are now 100% width and the container has a width specified instead!
• Used the exact box-shadow parameters from the design-file, so not quite sure what to make more subtle, but I reduced the box-shadow color opacity from 0.25 to 0.18.
• Social links are now an unordered list!
• Will look into doing it mobile-first on the next project!

Thanks, Roman, it's very helpful to get feedback like this. Have a great day! Tor

@torhuus Hi Tor, nice, that was really fast on fixes, glad I was helpful.

As for sass usage - try to not go 3 levels deep in nesting, otherwise it raises specificity selector, it's hard to maintain or overwrite styles. On bigger projects this can be an issue. Most of the times I try to follow css BEM naming convention, that helps with code structure and works great with preprocessors.

My comment regarding button was mainly alpha channel, so you fixed it already. In sketch file you can get correct values. As for social icons - links inside li, so user can go to proper social media page😉

Have a good one too, Roman

@rfilenko

I understand. I've read/heard a little about BEM, guess I'll have to dive deeper now!

Alright, great! Social icons now have a-tags ;)

Thanks again! Tor

@ApplePieGiraffe

Thank you for taking the time to help me out!

I initially had it at "cover", but changed it to "contain" because the mobile background did not look right. I have now changed it back to "cover" on desktop and "contain" on mobile.

Thanks! =D