@Bayoumi-dev
Posted
Hey Etinhandy, Congratulations on completing this challenge... Here are some suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main id="page-holder>
<div class="container">
//...
</div>
</main>
-
Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document...<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
I suggest you put
the socials
into thelist item
to add moresemantics
to your project...
<ul class="socials">
<li class="icons"><a href="https://www.facebook.com/"><img src="./images/facebook.svg" alt="facebook"></a></li>
<li class="icons"><a href="https://www.twitter.com/"><img src="./images/twitter.svg" alt="twitter"></a></li>
<li class="icons"><a href="https://www.instagram.com/"><img src="./images/instagram.svg" alt="instagram"></a></li>
</ul>
Hope this help!... Keep coding👍
Marked as helpful