Huddle page with HTML, CSS, and Bootstrap

Community feedback

• 

  Ahmed Bayoumi•6,700

  @Bayoumi-dev

  Posted almost 3 years ago

  Hey Etinhandy, Congratulations on completing this challenge... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main id="page-holder>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • I suggest you put the socials into the list item to add more semantics to your project...

   <ul class="socials">
     <li class="icons"><a href="https://www.facebook.com/"><img src="./images/facebook.svg" alt="facebook"></a></li>
     <li class="icons"><a href="https://www.twitter.com/"><img src="./images/twitter.svg" alt="twitter"></a></li>
     <li class="icons"><a href="https://www.instagram.com/"><img src="./images/instagram.svg" alt="instagram"></a></li>
   </ul>
  

  Hope this help!... Keep coding👍

  00

  Marked as helpful
• 

  Etinhandy•30

  @Etinhandy

  Posted almost 3 years ago

  After going through your suggestions, I now realise how important the main tag is for screen readers.

  Also, thank you for your tip on the socials. Thank you very much.

  00