Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Huddle-landing-page-with-a-single-introductory-section

Sarvotham Gowda•210
@sarvothamgowda
A solution to the Huddle landing page with a single introductory section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi folks,

My solution might not be optimized/the correct method. I used the grid to place the header, main, and footer. Using the grid-column/row property I aligned the child items and used flex too. Please review my code and let me how it can be improved better.

1 When the screen shrinks below 400px, the right side of the screen remains fixed but not the left side. I used max-width of 400px for the container. What might be the issue?

Thanks for reviewing my work.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Chamu•13,860
    @ChamuMutezva
    Posted almost 3 years ago

    Hi Sarvotham

    So far so good with your challenge. Here are some things to consider:

    • let your alt values be descriptive for the benefit of assistive technology users. A value like hero-img does not present a clear message to someone who is not able to see the image.
    • the register button seems to be an anchor element , it should kind of navigate to another section or page for the registration
    • the social icons are meant to be links to social media accounts, hence an anchor element should have been used
    • the body has a height: 100vh , change that to min-height: 100vh; . Min-height allows you to accommodate all the content by allowing scroll while height will cut off your content if it does not fit on the screen. Using dev-tools check that on small screens like 375px.
    Marked as helpful
  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hello Sarvotham Gowda, congratulations for your new solution!

    Your solution is perfect and also the design match everything the challenge requires. The only thing I see that can be an issue is the facebook icon that doesnt have the same size of the other social icons, to fix that you can create a class to manage the icon sizes, for example setting all of them with the same class with the size max-width: 24px and height: auto. This way you've a standard for the icon sizes.

    👋 I hope this helps you and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub