Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

i used flex box and float

chadrack• 90

@chadrack


Design comparison


SolutionDesign

Solution retrospective


Hi! I'm new at coding if you have any feedback to help me improve. thank you for your time.

Community feedback

Declan• 300

@declanslevin

Posted

While float works for what you've used it for, this is actually incorrect usage. Float was originally intended for wrapping text around an image and not for positioning elements on the page.

Instead you are better off using Flexbox as this was developed purely for positioning and layout. You can align items to the right of the screen by using justify-content: flex-end.

1
Solomon Ekrebe• 610

@krebeDev

Posted

Hi Chadrack, great work! Do check your page's Report and fix the accessibility and validation issues. I can help if you need more clarifications on these.

1

chadrack• 90

@chadrack

Posted

@krebeDev yes , i need help

0
Solomon Ekrebe• 610

@krebeDev

Posted

What specific area of the challenge do you need help with?

0
Declan• 300

@declanslevin

Posted

Hi Chadrack,

One thing you can quickly fix for the accessibility issues in your report is 'hashing' the anchor (<a>) tag href urls, e.g. <a href="#"></a>. It will satisfy the requirement for a link without causing the browser to leave the page if the anchor tag is clicked on.

Also when you use an <image> element, you should give it an alt attribute with a description of what the image contains or the purpose of the image. The exception is if the image is purely decorative.

Something you might want to consider is using an icon library such as Font Awesome for the social media icons in your footer. These use the <i> element instead of <img> so you won't have to provide an alt attribute.

Hope that helps!

1
Solomon Ekrebe• 610

@krebeDev

Posted

I also noticed the link to your live site is broken.

0

chadrack• 90

@chadrack

Posted

@krebeDev Realy! thank you . i'm going to fix it and also the accessibility and validation issues.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord