Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first website using scss and bem

TiredQuan 245

@TiredQuan

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I had a hard time nailing the exact design of the card's border-top, mine curved with the card but the one in the design doesn't do that, so I'm a little puzzled by that

Community feedback

P
Chamu 12,970

@ChamuMutezva

Posted

Greetings TiredQuan

  • notably missing in your html structure are semantic html elements like header, main etc. Where possible avoid using the div if there is a more suitable element.
  • a site has to have at most one h1 element - which points me back to the issue I mentioned above. One of the div must be an h1

Happy coding

Marked as helpful

1
P
Patrick 14,325

@palgramming

Posted

your issue is at the point where your mobile layout becomes your desktop half your desktop layout ends up outside the browser window. This challenge works good with a middle transition of 2 columns with 2 cards. This is easy to do using grid template areas to be able to rearrange cards with a few lines of code

Marked as helpful

1

TiredQuan 245

@TiredQuan

Posted

@palgramming I just changed the flexbox I used in the cards to grid and added another media query for 1200px

Thanks a thousand btw, I wouldn't know if I was wrong if it wasn't for you!

1
P
Patrick 14,325

@palgramming

Posted

@TiredQuan No problem glad I was able to help

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord