@mattstuddert
Posted
Excellent work on this project, Kevin! It looks great and works well!
My main piece of feedback would be to avoid adding event listeners to non-interactive elements. For example, you're using li
elements to switch timers and an img
element to open the settings modal.
Whenever you expect a user to interact with an element, you should use an interactive element (e.g. a' or
button`). This will allow people who can't/don't use a mouse or trackpad to use your app.
As the timer switchers and the settings trigger don't navigate to new pages, I'd recommend using button
elements to trigger the actions.
It's always a good habit to try navigating anything you build while only using your keyboard to see if you can still use the app. If not, it needs refactoring to make it more accessible.
I hope this helps. Keep up the great work!
Marked as helpful
@mrfinesse47
Posted
@mattstuddert Thanks for that, I will keep it in mind for the next project, and test projects with the keyboard + accessibility developer tools from now on.