Pomodoro Timer created with the Vanilla JS framework

Community feedback

• 

  

  Matt Studdert•13,611

  @mattstuddert

  Posted almost 3 years ago

  Excellent work on this project, Kevin! It looks great and works well!

  My main piece of feedback would be to avoid adding event listeners to non-interactive elements. For example, you're using li elements to switch timers and an img element to open the settings modal.

  Whenever you expect a user to interact with an element, you should use an interactive element (e.g. a' or button`). This will allow people who can't/don't use a mouse or trackpad to use your app.

  As the timer switchers and the settings trigger don't navigate to new pages, I'd recommend using button elements to trigger the actions.

  It's always a good habit to try navigating anything you build while only using your keyboard to see if you can still use the app. If not, it needs refactoring to make it more accessible.

  I hope this helps. Keep up the great work!

  11

  Marked as helpful
• 

  Vincent Yan•210

  @envincebal

  Posted almost 3 years ago

  Very well done! Everything works as it should and the app looks great on all screen sizes. The changes in the settings all work seamlessly. My only suggestion may be a personal preference. But I'd consider making the clock not count down immediately until you click on the clock. To me is just a usability thing. Other than that, great work!

  14