This comment was deleted 3 months ago
Solution
Design Comparison
SolutionDesign
Report
0Accessibility
issues0HTML
issues
Emmilie Estabillo's questions for the community
I tried to apply border-radius: 1.5rem to the main tag but it didn't work. Had to individually target every corner. Why is that? Any kind of feedback is welcome.
Community Feedback
- 0
- 0
Tente com px, em vez de rem.
- 0
Hi @alicepsz98 , thanks for the feedback! I wish the answer were that easy 🙂
border-radiuscan actually take both percentage and length values (such as px and rem).
- 3
Hi.
The issue is because children elements are overflowing so their borders are shown.
The solution is to remove all the
border-radiusthat you have and leave it only in the main tag + you must use theoverflow: hiddenproperty, so children's borders aren't displayedmain { ... border-radius: 1.5rem; overflow: hidden; }- 0
Hi @juanmesa2097 I've already tried this and it works for the mobile version. The desktop view has that popup that overflows the container, and applying
overflow: hiddenwill cut it up to the point of the container's border, which is about half of the popup. Sigh. Thanks for taking a look! - 2
@emestabillo you can still use it in the
image-containermain { border-radius: 1.5rem } main .image-container { width: 100%; border-radius: 1.5rem 0 0 1.5rem; overflow: hidden; }Those would be the only places where you would set the
border-radiusAnother possibility could be
background-clip: content-boxbut you still need to replicate theborder-radiusin theimage-container - 1
@juanmesa2097 Ah I see, this method will also work. Thank you so much!
- 0
@emestabillo of course, no problem.
- 2
Hey, generally setting border-radius and overflow:hidden on parent container works, but for popup you probably need to use js, coz on mobile hover wouldn't work. Nice solution though
Cheers, Roman
- 1
Hi @rfilenko , good point! The hover states wasn’t originally called for in the style guide but I added it anyway. The popup active state, on the other hand, doesn’t remove itself once applied on mobile..and that I might have to adjust by js. Thank you for the comment!
- 2
Emmilie, this looks exactly like the design. I can't even tell the difference! Great job! I did find a few areas of improvement besides the border-radius.
- The hover states should transition together. Currently, on desktop, when you hover on the CTA, the shared bubble transitions a little later. Onmouseleave, the button transitions quickly and before the shared button. There's no cohesion right now.
- Missing content
box-shadow. - The CTA doesn't work well on mobile. Either use an input button and make it pure CSS or use Javascript to toggle the states as the mobile user clicks on the CTA.
- 0
Hi @shashilo , great eye as usual! Will you be my mentor?? 😄 You're absolutely right about the CTA. I tried to be slick, and I paid the price lol. I'll revisit the project to include all above comments. Thank you so much!
- 1
Hi Emmillie, really nice solution!! Basically pixel perfect 👌 Really nice, organized, readable code too. I'll have to study more of your projects to learn some things from you! I just have one super minor suggestion for something you could fix. It looks like on a small mobile screen size like an iPhone 5, the attribution overlaps with the content on the page.
- 0
@En-Jen Hi Jen, I call that my trademark lol :grin: For single component challenges like this, my attributions are positioned fixed that's why it will always overlap with smaller viewports. It's something I'd really have to do something about. Thank you for the feedback!
PGive some feedback to emestabillo about their solution
Join our Slack community
Join over 20,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!