Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

QR code component

Nguyễn Trường An•60
@ntan2k3
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Петро•50
    @stadnik-petro
    Posted about 1 year ago

    Great job done! There is one caveat you have in the text different height from the original is a fashionable fix adding the value "line-height"

    Marked as helpful
  • Grace•32,130
    @grace-snow
    Posted 12 months ago

    Well done on completing your first challenge.

    I give feedback on this a lot and it’s almost always the same things as this is the challenge to lay down important foundations.

    So rather than repeat myself I’m going to point you to read others feedback I’ve left on this challenge.

    For example, see my comments on these solutions and use those learnings to refactor yours:

    • https://www.frontendmentor.io/solutions/qr-component-using-padding-and-border-radius-with-a-bit-of-font-css-IrBrFHDvWs
    • https://www.frontendmentor.io/solutions/responsive-barcode-page-using-css-media-query-and-grid-to-solve-it-all-Y-N1UTiLQi
    • https://www.frontendmentor.io/solutions/finished-qr-code-component-_AM0tpAazt
    • https://www.frontendmentor.io/solutions/qr-code-component-3ai6h6v_Xw

    Once you've fixed this one, go through your others and fix those too. And I need to stress -- Don't rush through lots of challenges before getting or at least reading others' feedback on the challenge and then improving what you've done using that feedback. All rushing through will do is repeat mistakes over and over, which then will be very hard work to go back and fix on so many. It's the feedback where you will get the value from this platform.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub