QR Code design using HTML5 and CSS3 / Responsive Design, Position

Solution retrospective
Hi Everyone! This is my very first challenge and project that I started working.
- I do have some difficulties when it comes to position absolute/relative ( Like, when do I know I am supposed to use this )
- Responsive design: I had a tough time about doing it so. I set up @media screen for 480 px but I do not feel it goes smoothly as it should.
- Best practices: I would like to know if you have tips so next time I could start coding already in a responsive way. Sometimes I face a difficult when it comes to fill the the entire background ( For example, what would be the difference between using width auto and 100% )
Feel free to provide me any feedback! Anything will be more than welcome!
I will start doing more projects so then I can get more clear ideas and develop my practices! :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @correlucas
👾Hi Damiao, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
- Use
<main>
instead of a simple<div>
this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a<main>
block and that<div>
doesn't have any semantic meaning. - Replace the
<p>
containing the main title with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level. - Add a margin of around
margin: 20px
to avoid the card touching the screen edges while it scales down. - Use relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
- Use
- @vanzasetia
Hey, Damiao! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉
To place the card in the center of the page, I recommend using flexbox or grid. These modern techniques are more robust than absolute positioning and require less code to implement. I recommend making the
body
element as the flex (or grid) container.I recommend fixing the HTML first.
- For the
page_background
, you can usebody
element instead. - For the card element (or the
white_square
div), I recommend using amain
element instead of adiv
. - The alternative text for the QR code should tell the users what the QR code is for.
- For the
texttitle_qrcode
, I recommend usingh1
instead.
For the responsiveness of the site, there's no need for media queries. The card only needs a
max-width
to prevent it from filling the entire page. Setting awidth
is not allowing the card to shrink on tiny screen sizes. For the height of the card, let the elements inside the card control it.For your reference, you can see my solution. You can use it as a guide to improve this solution.
I hope this helps! Happy coding! 😄
- For the
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord