Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive FAQ accordion using JS

Guliye 290

@guliye91

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


HI Coders! I just finsihed 'FAQ accordion Card'. I used Javascript. DONT BOTHER THE DESIGN. I just wanted to practice my JS knowledge.

kindly gi through and give me feedback on issues of js functionality in js.

Community feedback

@Amir-Jacobs

Posted

Hi Guliye

I noticed a few things about your Javascript:

  • I'd use functions to make clear what is happening. You could make a function called resetAccordion() and a function called showAccordion().
  • I'd make a bit more use of comments.
  • The accordion can only be opened by clicking the icon, but it'd be more user-friendly to have it open upon clicking .question.

Have a nice day.

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord