@mattstuddert
Posted
Hey Joshua, awesome work on this challenge. Your solution looks really good! I can't see any issues with the accessibility or performance side. The only slight issue is that some of the flags don't change if you play around with the search and filter. Also, on a purely UI side, you could set a height on the flags and use object-fit: cover so that they're not varying sizes.
I hope you enjoyed the challenge. Keep up the great work!
@somecallmejosh
Posted
Hey Matt! Thanks for your feedback. I've updated based on your suggestions. I believe the wonkiness with the filtered flags had something to do with the lazy loading of the images. I set them back to regular images and things work fine. I'll have to do some research into why that was happening. BTW, I found this site in your No CS Degree interview from September. Been wanting to tinker on one of these projects for a while. I'm very excited by the work you're doing here.
@mattstuddert
Posted
@somecallmejosh nice work resolving that issue! Odd that the lazy loading was interfering.
That's great that you read the No CS Degree interview and that you like the idea behind the site. If you ever have any feedback or ideas please feel free to message me. Also, if you ever fancy giving people feedback then feel free to just dive in. The more people providing useful feedback to each other the better! š
@somecallmejosh
Posted
@mattstuddert I will do my best to provide constructive feedback on other projects. Giving good feedback is a good skill to have. Need all the practice I can get. :-)
See you on the next project.
