Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 5 years ago

With HTML, CSS and Flexbox

Tobi-dev99•200
@Tobi-dev99
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am new to web development(coding in general) and I think, I write a very messy code. Can someone point out my mistakes where I could have saved time and wrote unnecessary code?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Matt Studdert•13,611
    @mattstuddert
    Posted over 5 years ago

    Hey Tobi, congrats on submitting your first solution! You've done a really good job. Your code isn't very messy at all! After having taken a look I've got a few pointers that will hopefully help:

    • For your . heading class, I would recommend not using a section here. A section is typically used to group a larger collection of themed content. For example, a testimonials section on a page. For this smaller grouping of content, a div would be absolutely fine.
    • You've got h1 and h3 headings but no h2. Be sure to avoid skipping heading levels unnecessarily, as this can cause accessibility issues.
    • You don't need the div wrapping the anchor tag. You could just style the anchor tag directly.
    • In the Why Us area, I'd use a ul with li elements to create a list instead of having separate p tags for each item.

    You've done a really good job. Let me know if you have any questions 🙂

  • Saurav Chamoli•370
    @sauravchamoli17
    Posted over 5 years ago

    Well done!on your project.The improvements you can make in this project are: 1. the per month text should be centered with related to the $29 text.Add a box shadow and hover state to your sign up button.Add a box shadow and border radius to your main container. Move the why us subtext in an unordered list instead of an paragraph and remove padding from them.

    Keep up the good work!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub