Emmanuel Lopez
@EmLopezDevAll solutions
Ecommerce Product Page
#sass/scssPSubmitted 1 day agoHonestly the Javascript. I know I have code that can be simplified or even condensed but in fear of breaking anything like I did several times I left it as it. If someone could take some time and let me know what areas can be better and how would be amazing. The
addToCart()and the functions to update the imagelines 149-172are definitely ones I would like feedback on. These are the types of functions I need the most help in to learn of better approached.News Homepage
#sass/scssPSubmitted about 1 month agoSince this challenge revolves mostly around accessibility I would like feedback on whether or not this challenge meets accessibility standards and how it could have been better. Also my approach to adding a transition to the sidebar, I am sure there is a better way then using a
setTimeoutlike I did.Contact Form
#sass/scssPSubmitted about 1 month agoI would like some feedback specifically on the validation code. Is what I have okay? Is there a better way? Also any general feedback in more than welcomed.
FAQ Accordion
#sass/scssPSubmitted about 1 month agoI would say the scss used to apply the styling to the
<details>tag, should I have done it with JS instead?Interactive Rating Component
#sass/scssPSubmitted about 1 month agoIs there a better way to handle events in the JS file?
Frontend Quiz
#sass/scssPSubmitted about 2 months agoThe three JavaScript files:
- Was the way I handled all the JS a good approach? What could have made it better?
- Is there a better way to fetch data and pass it along?
- Is there a better way to handle a light/dark theme?
- In general what isn't good and how can I make it better?
Password Generator
#sass/scssPSubmitted about 2 months agoI definitely would like feedback on the JavaScript.
I cleaned up the logic as much as I think I could but I am sure there is more I could have done or a better approach.
Would like feedback in general on the file but for a bit more specificity these two logics:
const randomCharacter = () => { finalPW = ""; const checked = isChecked(checkedOptions); while (finalPW.length < lengthValue) { const randomIndex = randomNumber(checked.length); const randomCategory = checked[randomIndex]; const categoryValues = passwordCharacters[randomCategory]; const randomCharAt = randomNumber(categoryValues.length + 1); const randomCharacter = categoryValues.charAt(randomCharAt); finalPW += randomCharacter; } }; const finalPwStrength = () => { const checkedLength = isChecked(checkedOptions).length; if (lengthValue < 15 && checkedLength === 1) { changeGauges(1, "very weak"); } else if (lengthValue < 15 && checkedLength === 2) { changeGauges(2, "weak"); } else if (lengthValue < 15 && checkedLength > 2) { changeGauges(3, "medium"); } else if (lengthValue >= 15 && checkedLength === 1) { changeGauges(2, "weak"); } else if (lengthValue >= 15 && checkedLength === 2) { changeGauges(3, "medium"); } else { changeGauges(4, "strong"); } };Tip Calculator App
#sass/scssPSubmitted 2 months agoDefinitely the JavaScript. I would like feedback on what I have and if I could have made it more efficient.
Time Tracking Dashboard
#sass/scssPSubmitted 2 months agoI would like some feedback on the
main.jsfile was there a better or more efficient way of writing the js.Newsletter Sign Up
#sass/scssPSubmitted 2 months ago- I would say mostly I would like feedback on the JS. I think I did everything well but is there something I missed or could have done better.
Article Preview Component
#sass/scssPSubmitted 3 months ago- I would like feedback on my solution to the toast/tooltip and what I could have done better.
- Also I would like feedback on how to make the hero image better. It looks crammed up to me.
Meet Landing Page
#sass/scssPSubmitted 3 months ago- I would like some feedback on my approach to making the site responsive. Are there things I could have done better?
Testimonials Grid Section
#sass/scssPSubmitted 3 months agoI would definitely want feedback on my usage of CSS grid and making it responsive. Was my approach good? and how could it have been better.
Four Card Feature Section
#sass/scssPSubmitted 3 months ago- I know the file structure was is a bit over kill for such a small project, however I wanted to get opinions on it to use later on in larger scale projects.
- Was my use of
clamp()correct? - Is there anything else I could have done different to make the site more responsive? or accessibility friendly?
Product Preview Card
#sass/scss#bemPSubmitted 3 months ago- Was the way I set up and used SCSS the best approach?
- Could I get help converting one of my font-size instance to use
clamp()or whatever responsive method? I kind of get it but would like a concrete example using what I have to grasp it better. - Thoughts on BEM? Did I use it properly?
Recipe Page
PSubmitted 3 months ago- Was there a better way I could have approached the media query?
- Was the way I laid out the HTML fine? Or should I have not used a header tag for the banner img?
Social Links Profile
PSubmitted 3 months ago- Were the right HTML tags used
- Was the approach to make the whole li tag clickable correct? Is there a better way?
- Did I properly implement the hover and focus states.
Blog Preview Card
PSubmitted 3 months agoI would like to get some feedback on the HTML tags I used, could I have made it more semantic? Also advice on how I could haver made the styles.css a bit more organized or clean.
