kristynavulcova• 150
@kristynavulcova
Submitted
Foued
@Foued80
All comments
- Foued• 655
@Foued80
Posted
Very nice well done :D
0 - Jibreel• 300
@jibreel1
Submitted
This project really helped me with the basic concepts of React. Your feedbacks are highly welcome.
Foued• 655@Foued80
Posted
Hi, Jibreel great work for this challenge
there is an issue with " + " it calls a function that increment "counter" that's ok but it is not supposed to show the quantity on the cart bdge (top right screen) untill you hit the "add to cart" button.
0 - Paula Isabel• 230
@paulaxisabel
Submitted
Hello everyone ! 👋
Here is my solution for this challenge. Let me know your thoughts and feedbacks on this. Thanks!
Foued• 655@Foued80
Posted
Great job Isabel, the animations are great!
0 - Holat• 640
@Holat
Submitted
I decided to use sass and found out its very easy to use for projects like this sass allows nesting and importation of different scss files into one so it makes it easy to partition website sections. Also followed through MRZ.Code.Manufacture on youtube it was a long one. But yes i finished it. Ill love feedbacks on better ways it could have been done.
Thanks
Foued• 655@Foued80
Posted
hi, geat work.
on desktop view when hovering over navbar links i can see the border-bottom shifting due to the boxsizing property, you can fix this by adding margin-bottom:-3.5px;
header .logo .menu ul a:hover { color: #1d2025; text-decoration: none; font-weight: 700; border-bottom: 3.5px solid #ff7d1a; margin-bottom:-3.5px; }
and to prevent the links to shift right when hover over due to the font weight change, try to change opacity or color unstead.
cheers
Marked as helpful
0 - Romeo Noveanre• 200
@kraken-afk
Submitted
Feed back are needed. please give your opinion about my solution.
Foued• 655@Foued80
Posted
hi, great job, on desktop view you forgot the thumbnails (design/desktop-design-lightbox.jpg).
1 - CorizCoder• 20
@CharlesCypher
Submitted
- The sidebar dropdown was difficult for me.
- I am not sure of the JavaScript code and some CSS stylings.
- I need help, to learn best practices in JavaScript. Please indicate any fault. I will love to see some feedback :)
Foued• 655@Foued80
Posted
hi, CorizCoder
Goodjob, i had the same trouble with the sidebar dropdown menu specialy the padding and margins to hide the submenu;
check my css only solution for this challenge no single line of javascript was needed, i used input:checkbox with css ~ sibling
your sidebar is missing a backdrop to the left, and for the best practice i suggest checking bootstrap's code for navbars and dropdown menu for inspiration
cheers.
Marked as helpful
1 - Bogdan-Mihail Pavel• 625
@codeguy9
Submitted
Hi guys.
This one was tough. I tried to make it responsive but I quit. My nerves started to come out. Thanks for the comments.
Foued• 655@Foued80
Posted
hi,
Here a fix for the the reviews section
.flex-machine { display: flex; align-items: center; }align-items:center will stop the avatar from stretching
can you tell me how you made the paragraph to shrink and grow with the viewport, i dont see clamp or font-size relative to viewport anywhere in your css :s i may learn something here :O
0 - Menna Rashad• 90
@Menna-Rashad
Submitted
Feedbacks are always welcome ^_^
Foued• 655@Foued80
Posted
hi,
-
the desktop view needs a container with a max-width of 1440px
-
hovering over the nav links shift the content try to force border to 0 on the li's
-
try the aspect-ration preperty to set the corect width/height of background images
-
don't use duplicate IDs check your solution report and fix the problems
Marked as helpful
0 -
- Heritier Akilimali• 310
@heritio
Submitted
i keep getting scrollbar and dead space on mobile version even though i have set the width on the body to 100%-95%, sometimes there is no dead space and no scrollbar, and sometimes there is, im not sure why that is happening. I would love some feedback on how to center the body and have no dead space that makes the x scroll bar apear. Thanks for the feedback
Foued• 655@Foued80
Posted
Hi Heritier,
Be aware that the css is processed from top to bottom, at the begening of the file you put :
body> margin: 9vh auto; and then @media body> width: 95%;
for mobile view, you should override the rules if you want something different and remove duplicates @medias if you wan't it to stay as it is .
cheers
Marked as helpful
0 @odpinerosh
Submitted
I would like some feedback on my code. What could have been better done?
Thank you in advance.
Foued• 655@Foued80
Posted
Hi Oscar, well done,
-Not sure if an email like this [email protected] is a valid email ( .c) need at least 2 chars according to Domain Naming Conventions. -The background pattern isn't well scaled nor well positionned
cheers.
Marked as helpful
0- Keshava Varma• 20
@half-clutch
Submitted
How do i make the background image shrink with the screen size?
Foued• 655@Foued80
Posted
Hello, use th background-size to scale up or down with VH or VW units.
0 - David Maillard• 375
@DavidMaillard
Submitted
I chose the use ::before and ::after to position the background patterns.
I would love to have constructive feedbacks on other ways to do it.
Foued• 655@Foued80
Posted
Good job, i personaly used background images, your design miss the mobileview.
Marked as helpful
0 - Foued• 655
@Foued80
Submitted
FAQ accordion card mobile first design, no javascript using checkbox hack, css only.
Foued• 655@Foued80
Posted
Thank you for the feedback, here what i fixed :
- Mobile display down to 320px.
- LABEL html validation issue:
<li> <input type="checkbox" id="toggle1" /> <label for="toggle1">How many team members can I invite?</label> <img class="arrow" src="images/icon-arrow-down.svg" alt="" /> <div class="card_faq_a"> You can invite up to 2 additional users on the Free plan. There is no limit on team members for the Premium plan. </div> </li>- Lowered transition to 0.5s;
On desktop view :
- Added shadow to the box and fixed the positioning;
- Reduced font-size, paddings and margins to fix the accordion display when fully expanded;
- Added hover effect on questions (color, cursor)
0 - Carl Wicker• 1,055
@carlwicker
Submitted
This was a lot more challenging than I originally thought. The background took several attempts to get right. Getting the user image in position was a pain in the ass too but got there in the end.
I learned a few good techniques with this challenge, any feedback is appreciated.
Foued• 655@Foued80
Posted
svg top and bottom took me 70% of the developemen't time, i'm not sure if i got it right :/
0
