Matheus Pergoli• 130
@matheuspergoli
Submitted
I don't know yet how to validate an email properly, so if you have any feedback I'd appreciate it :)
Adeniyi Smart
@Iamweird2
All comments
- Adeniyi Smart• 520
@Iamweird2
Posted
Hi Matheus👋, nice job so far👏. To improve your code, follow these tips
-
Avoid styling elements by name or id, but style elements via class
-
According to the generated report, you used an element not currently supported by many web browsers, try using an alternative.
-
Check the generated report and try to resolve as many HTML issues most of which are issues from the CSS transform property.
-
For form validation, you can use regex in your javascript file, you can find a link to a very simple example below:
I hope this helps, Do have a nice day 👍
1 -
- Annika• 20
@AnniK93
Submitted
Adeniyi Smart• 520@Iamweird2
Posted
Very nice work @AnniK93 to improve your code, you can do the following
-
use class selector allthrough and avoid styling elements via tag name and id to avoid issues with specificity. for example, add a class(.body) to the body element then
-
center the container by
.body{ display: flex; justify-content: center; align-items: center } -
avoid using static units for font sizes such as pixels but use units that resizes based on browser size such as em or rem.
I hope this helps. Have a nice day.
Marked as helpful
0 -
- Andrew• 90
@L1m1tz
Submitted
This is one of my first js projects
I've done most of the challenge just missing the right colors for the inactive buttons and some styling for the response.
any tips on ways to improve will be greatly appreciated.
Adeniyi Smart• 520@Iamweird2
Posted
Hi, nice work so far.
-
To be very sure of the colors, you can open the design file on your browser, then open developer option by (control shift i) and search around for a dropper. you can also search online how to find a color dropper for your web browser.
-
You can also center the details on the submit page to improve the aesthetics.
-
Endeavor not to use style elements by tag name or with id, using classes all through saves time debugging and prevent issues with specificity
-
Using static units such as pixels for font size is also not advisable since page sizes vary, specify for font size in relation to the browser window size using rem or em.
I hope this helps. Have a nice day.
Marked as helpful
1 -
- PRitu Melroy• 130
@ritumelroy
Submitted
Adeniyi Smart• 520@Iamweird2
Posted
Hi, nice job so far, In your HTML, add <html lang="en"> Then try generating a new report, I think most accessibility issue is because of the report.
Marked as helpful
0 - Shade• 300
@ShadeVI
Submitted
Adeniyi Smart• 520@Iamweird2
Posted
Hi, nice job so far. To improve your code, you can do the following
-
Add an hover effect to the button by
.dice-btn:hover{ cursor: pointer; box-shadow: 0px 0px 40px hsl(150, 100%, 66%); } -
Try not to style via id and tag name but use classes instead
-
One should be able to input an advice number and then call the advice when you click the button
I hope this helps even a little. Have fun
0 -
- PFranklyn Valdez• 150
@fvaldez29
Submitted
Adeniyi Smart• 520@Iamweird2
Posted
Nice job so far,
From previewing the site, i found a few things that needs adjusting
- validate the input fields
- add an hover effect on the button
- change the background-color of the button om hover
- to validate the email, you can check this site on hint Text
Marked as helpful
0 - Leonard• 80
@Leonard-O
Submitted
I would like comments on anything I can work on
Adeniyi Smart• 520@Iamweird2
Posted
Hey, nice work so far, To center the container, add the following to the body:
display: flex; justify-content: center; align-items: center;
then you can remove margin: auto; from the container.
also you can move the attribution all the way down by adding the following:
body{ position: relative; } .attribution{ display: absolute; bottom: 10px; }
1
