Michael Bishop• 1,070
@MikeBish13
Submitted
Sahas saurav
@SahasSaurav
All comments
- Sahas saurav• 745
@SahasSaurav
Posted
great solution and pixel-perfect site ... Where did you learn scss any crash recommendation?
0 - Chloe Echikson• 220
@cloworm
Submitted
Hello Everybody :)
I used this challenge as an opportunity to learn how to use React's
useContextanduseReducertogether to manage the timer and theme states. Would love to hear any feedback!Sahas saurav• 745@SahasSaurav
Posted
great animation and responsive even i have also tried this challenge just check my solution link- https://next-pomodoro.vercel.app/ and please give feedback to me and my github repo https://github.com/SahasSaurav/next_pomodoro and even i also soved the state maagement with context api and useReducer just give a look to it
1 - Chloe Echikson• 220
@cloworm
Submitted
Hi Everyone!
I put a lot of effort into getting the flip animation right. Let me know what you think!
I also added a bonus feature that lets you customize the date you're counting down to. Just pass in an ISO 8601 Date String into the date query param to use it.
Countdown to Christmas 2021: https://countdown.cloworm.vercel.app/?date=2021-12-25T05:00:00.000Z
Countdown to 2022: https://countdown.cloworm.vercel.app/?date=2022-01-01T05:00:00.000Z
Sahas saurav• 745@SahasSaurav
Posted
Hey, great job and really love the way you are using svg. Everything looks fabulous and responsive
1 - Matt Kissinger• 60
@MatthewKissinger
Submitted
- With the desktop background image:
I was having difficulty having it only cover the bottom half of the page without repeating so I decided on having it cover the entire background starting at 380px. Any tips or hints to solve this problem would be appreciated.
Sahas saurav• 745@SahasSaurav
Posted
use background-size:contain background-repeat: no-repeat and background-position: bottom for background image
0 - Saumya Verma• 565
@nikkuv
Submitted
Any suggestions and feedback are welcome!
Sahas saurav• 745@SahasSaurav
Posted
use the max-width in form reduce the width in form element and decrease the line-height the h1 in larger screen
form{ max-width:550px }
0 - Sol B W• 80
@solybarr
Submitted
Hi I'm a little disappointed by this one, it was harder than I thought. I had trouble with the relative/absolute positioning of the Call to action that overlaps the footer. I couldn't center it the normal way with margin 0 auto because of the positioning. I couldn't size it correctly either. Thanks for any help.
Sahas saurav• 745@SahasSaurav
Posted
the reason behind the accessibility issue is each must be uniquely identity from other so use aria-label attribute and this aria-label attribute also help with screen reader how to describe about the link. <a href="www.facebook.com" aria-label="facebook">Facebook</a>
0 - Saumya Verma• 565
@nikkuv
Submitted
I'm improving a lot because of feedback !! so anyone who wants to give their feedback ...please!!
Sahas saurav• 745@SahasSaurav
Posted
use flexbox to align it in center both horizontal and vertical
0 - Muhammad Kevin• 50
@muhammadkevinpf
Submitted
Any feedback will be appreciated
Sahas saurav• 745@SahasSaurav
Posted
using aria_label to uniquely identify the each input and fix the image by using the object-fit:contain on img tags
0 - Eloisa• 160
@eefborromeo
Submitted
What is the best way to implement responsive images? I tried using
srcsetfor this solution but I am a little unsure if I used it correctly or if there is a better way to implement responsive images.Sahas saurav• 745@SahasSaurav
Posted
You see Kevin Powell video on YouTube for img srcset and you are prefectly img srcset https://youtu.be/2QYpkrX2N48
0 - M3gumi• 385
@takameg
Submitted
Not sure if this is what I am supposed to do with javascript in this challenge, although it's switching the contents. Any feedback/advice to improve my code is highly appreciated.
Sahas saurav• 745@SahasSaurav
Posted
Fix the position of slide btn
1 - Sarvagya Sharma• 555
@sarvagya2545
Submitted
This is my first time using scss! Please tell me what you think of my solution.
Sahas saurav• 745@SahasSaurav
Posted
design is good but to get rid of accessibility issue use aria-label to uniqueidentify the each checkbox
1 - Hemanth• 120
@hmnth07
Submitted
Open to feedbacks! :)
Sahas saurav• 745@SahasSaurav
Posted
using button type submit and in a link use aria-label attribute to uniquely identify the each link
0 - Snayder• 60
@snayder1900
Submitted
Agradeceriaa sus comentarios para seguir mejorando, gracias.
Sahas saurav• 745@SahasSaurav
Posted
decrease the width of box and align the box in center using flebox diplay:flex; justify-content:center; align-item:center;
0 - Ynnk• 170
@HYannick
Submitted
Any feedback on the code architecture or css improvement are welcomed !
Sahas saurav• 745@SahasSaurav
Posted
nice work but you can improve liltle bit in loading time of page and while change the size browser the dont stay it properly what i mean that spanning the size of browser image center it self
0 - Obi Zim• 195
@Obizim
Submitted
If you happen to see this, please I request your feedback
Sahas saurav• 745@SahasSaurav
Posted
reduce width of form it looks like stretch out and you have change the color of placeholder to red and by the good work
0 - Magda Kokot• 1,425
@magdakok
Submitted
Hello people! :) I followed Matt's suggestion and coded mobile-first, what seems to be a bit more toilsome, but rewarding as well. For now, I know I have to work on consistency of BEM naming, there's form validation that needs improvement (I added an issue on GitHub repository).
All suggestions are very, very welcome! :)
Sahas saurav• 745@SahasSaurav
Posted
hey i just curious how you added loading animatiom?
0 - Jurijus• 300
@juryous
Submitted
feedback appreciated
Sahas saurav• 745@SahasSaurav
Posted
input and link are not uniquely identified so use aria-label attribute
0 - Rose Grondin• 60
@lady-rosie
Submitted
Sahas saurav• 745@SahasSaurav
Posted
Really love the way you plays with colors in this challenge.
0 - Saumya Verma• 565
@nikkuv
Submitted
Do you like this page?Your feedback is very important to me.I'd love to hear from you:)
Sahas saurav• 745@SahasSaurav
Posted
Hey use aria-label attribute to uniquely identity input field and link by screen reader.that is cause accessibility issue and remove action attribute or provide value to action because action can't be empty
1 - Adler G Luders• 1,580
@adluders
Submitted
This was my first time using React or an API on my own for that matters, so please whatever feedback that can be provided would be extremely appreciated.
Sahas saurav• 745@SahasSaurav
Posted
try to have equal height for each flag card so you dont break the consistency of design and at desktop you have too much width for card
1 - Adler G Luders• 1,580
@adluders
Submitted
This was my first time using React or an API on my own for that matters, so please whatever feedback that can be provided would be extremely appreciated.
Sahas saurav• 745@SahasSaurav
Posted
try to use aria-label for inputs fields so the screen reader can uniquely identify them and this also reason for your accessibility issue
1 - Upamanyu Das• 315
@tintindas
Submitted
Constructive criticism is always appreciated.
Sahas saurav• 745@SahasSaurav
Posted
hey you forgot to add circular curve img and decrease white spacing between two section
1 - Saumya Verma• 565
@nikkuv
Submitted
How's it? I'd love to hear from you guys!!
Sahas saurav• 745@SahasSaurav
Posted
hey everything is nicely done and just keep up.But i feel each card has lil bit harsh bottom box shadow
1 - Brian Bantigue• 290
@bignatue
Submitted
Sahas saurav• 745@SahasSaurav
Posted
hey you solve your accessibility issue by providing real links to the href of a tag . Empty href always cause accessibility issue and try to label for each input field and have id to unique identify eacg input field
0
