Alif Panglima Nurda• 135
@blurrypxl
Submitted
Hello guys, I just completed this challenge. If you have any suggestions, I would really appreciate it. Thank youu
ToNisamBioJa
@ToNisamBioJa
All comments
- ToNisamBioJa• 330
@ToNisamBioJa
Posted
Good job on this one.
It is responsive and looks like the original design.
One thing I would suggest is that you use more class names. It isnt good practice to nest elements in css this much (for example: main header h1 span ). Try to look into some naming conventions to make the code a little tidier.
Overall great job. Keep it up and happy codding!
Marked as helpful
0 - Anwar• 375
@Anwar11234
Submitted
any feedback would be great
ToNisamBioJa• 330@ToNisamBioJa
Posted
Nice job.The site is responsive and looks good!
Only thing is that your cards stretch a little bit too much on desktop. You can just change the max width on the container from 80% to 75/70% and it should look fine then.
Also your text isnt centered on mobile view but thats about it!
Keep up the good work and happy codding!
0 - E_X_E• 295
@Alex-AR-LR
Submitted
I would like to know if you think I use good practices or what should change but any comment is welcome!
ToNisamBioJa• 330@ToNisamBioJa
Posted
Really good job here!
The site looks really good on desktop and mobile.
Only thing I could recommend is that you put a max-width on your cards so they dont stretch on tablet sizes. Also try to make more media queries for different screen sizes, do some research on that.
Keep up the good work and happy codding!
Marked as helpful
0 - Felix Criollo• 575
@FelixCriollo
Submitted
any advice on my code spaghetti is welcome
ToNisamBioJa• 330@ToNisamBioJa
Posted
The page is responsive and look like the original design.
Keep using comments in your css it makes it more readable.
Great job here. Keep it up and happy codding!
Marked as helpful
0 - TheVirtuoso• 20
@CelestialVirtuoso
Submitted
Any feedback is appreciated :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great job!
Just add a box shadow on the card and thats it.
Keep up the good work and happy codding!
1 - Moises• 60
@devmoises
Submitted
This challenge is very interesting, it has its details to consider, I really liked it. I await your advice and recommendations. Thanks.
ToNisamBioJa• 330@ToNisamBioJa
Posted
Hello!
Really good job on this one. You got it really close to the original design and added a nice hover animation.
The only thing you could change is the border radius but thats about it.
Keep it up! Happy codding!
Marked as helpful
0 - David Maillard• 375
@DavidMaillard
Submitted
I tried to do an adaptative module. I don't know if I did the right choice but it looks right to me. For the responsive of the image, it may look a little weird but I chose to keep the focal point on the smiling woman.
I am open for other points of view :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great work here!
It is responsive and looks great everywhere.
Keep it up and happy codding!
0 - VladimirBrscic• 775
@VladimirBrscic
Submitted
Hello, i would like to now if my html semantics are correct. Thanks!
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great job here!
Your html semantics are great.
Keep it up and happy codding!
0 - Chirag Jain• 10
@cjain2077
Submitted
This is my first time uploading a solution on Frontend Mentor. Are there any improvements that can i make in this column
ToNisamBioJa• 330@ToNisamBioJa
Posted
Congratulations on your first Frontend Mentor solution!
You have done great. The site is responsive and very close to the original design.
The only thing that you could add is a bigger line height to the text.
Keep it up and happy codding!
Marked as helpful
0 - Benjo Quilario• 1,810
@benjoquilario
Submitted
Hello, this is my 7th challenge and first time using grid layout this challenge is so fun and it takes 3 hours for me to complete this challenge.
Feel free to drop your suggestion or feedback. ^^
ToNisamBioJa• 330@ToNisamBioJa
Posted
You have done great work here!
The only thing is that you forgot to put a border radius. But that is minor.
Good job on this one. Keep it up and happy codding!
0 - Javier Labrador• 95
@JALCH-1512
Submitted
I'm improving my clean code with css :) some feedback would be wonderful :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great work!
One thing I would suggest is that you move back your media query to 900px because the card stretches too much above 900px, especially the button. Also you forgot to change the border radius in the media query-on the sedans card(bottom left and top right) and the luxury card(bottom left and top right).
But all around great job here. Keep it up and happy codding!
0 - Gutka• 65
@karbowskam
Submitted
I'm on fire! (I think? :D) But seriously - I hope the effect is quite good :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
You indeed are on fire!
One small thing is that you forgot to put border radius on your boxes.
Good work here. Keep it up and happy codding!
Marked as helpful
0 - Hyun Don• 105
@hyundonny
Submitted
Hello everyone! This was my second challenge on Frontend Mentor. I would appreciate any sort of feedback.
Thanks! :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great work!
It is responsive and looks good. I noticed that your background isnt gray and I think that you could have moved your media query to 900px or 1000px. But these are small things.
Very good solution. Keep it up and happy codding!
Marked as helpful
0 - Vanza Setia• 27,855
@vanzasetia
Submitted
Hello Everyone! 👋
This challenge was so hard, especially when trying to make it responsive. I was doing this challenge on my Android phone. Hopefully, it looks good on your deskop. 😅
Of course, any feedback is appreciated!
That's it! Happy coding everyone!
ToNisamBioJa• 330@ToNisamBioJa
Posted
Very good job here!
It is completely responsive everywhere!
You have done a great work here, especially knowing you coded this on a phone.
Keep it up and happy coding!
Marked as helpful
1 - Betty Spurgeon• 10
@bettyspurgeon
Submitted
I know my submission isn't the same as the given design in many ways, but I'm happy with the look of it.
Please point out issues with the code or how the design could be improved. Thank you :)
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great job here!
You got very close to the original design and you should be happy with this one!
Keep it up and happy codding!
0 - Marlon Passos• 940
@MarlonPassos-git
Submitted
When placing the element I had to use some "magic numbers" in the margin of my elements to make those spaces in the user part. Is there a cleaner way to do this without having to put infinite DIVs in the code?
I also tried using BEM to organize my classes in CSS but I don't know if how I used it was too much
ToNisamBioJa• 330@ToNisamBioJa
Posted
Pretty good job!
Aside from a couple of differences(like the width of the card) its pretty close to the original design.
Keep going. Happy coding!
1 - Deepak Pradhan• 10
@varun2948
Submitted
Just wanted to make sure the 99vh i have used on css style for height is it gud to do on that case or not.
ToNisamBioJa• 330@ToNisamBioJa
Posted
Great job on this one!
Just change your media query to 900px because you get a little sidescroling around 800px.
If you want to learn how to make designs like this even more responsive i would recommend that you check out Kevin Powells "conquering-responsive-layouts" course(or his yt chanell about responsive design).The course is completely free and believe me you could really benefit from it.
But all around good job. Keep up the momentum!
0
