Skip to content
OverviewSolutions
9
Comments
3
Ekure Edem
@astraldev

All comments

  • Ekure Edem•260
    @astraldev

    It seems you forgot to center the card vertically.

    Also, the size (width) of the card is kinda static and doesn't change on different screens.

    Also, the ntf image is supposed to be rounded... The best way to do it is to use a div as a container, set the border radius and set overflow to hidden.

    e.g

    HTML

    ...
<div class="container">
  <img src="..." alt="..." />
</div>
...

    CSS

    .container {
  /*Other styles*/
  border: 0 solid transparent;
  border radius: 1.5rem;
  overflow: hidden;
}
  • Ekure Edem•260
    @astraldev

    You could have centered the Card..

    I just checked your code

    .container {
  margin: 2rem;
  display: flex;
  justify-content: center;
  height: 37rem;
}

    It turns out that, you could have added the align-items property to center the card on the vertical axis

    It could have been

    .container {
  margin: 2rem;
  display: flex;
  justify-content: center;
  align-items: center;
  height: 37rem;
}
    Marked as helpful
  • Ekure Edem•260
    @astraldev

    Honestly, I think it would have been better if you used plain CSS for that by setting the height of the barto be the price in percentage tho as in my own solution at least, you'll have more control over the bars....

    Then if the price is greater than 50, change the colour....

    You can check out my solution here

    https://www.frontendmentor.io/solutions/expenses-chart-component-with-vuejs-4fUiJTIs_P

    Marked as helpful