Skip to content
OverviewSolutions
67
Comments
10
Azzy dvyastia kesuma
@azzykesuma

All comments

  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    congratulations on finishing the project, well done!, maybe i can try giving some comments that may help you in the next project

    • try mobile first approach when implementing fm challenge , meaning that instead of using max-width for a baseline for responsive, try using min-width, that way you can structure your code better, as you have a mental image for various breakpoints like @media screen and (min-width: 768px) is designed for tablet screen and above, whereas below it, it targets the mobile screen. using tailwind will make this whole process easier ,as you just need to specify the base class and the breakpoints example <div className='flex flex-col md:flex-row'>...</div> will make your div has a flex col on mobile to tablet, and row on desktop.
    • i think you need to check this block of code
            window.addEventListener('resize', () => {
            if(window.innerWidth <= 376) {
                setIsMobile(true);
            } else {
                setIsMobile(false);
            }
        })
    });

    useEffect(() => {
        if(isMobile) {
            if(menuActive) {
                ref.current.style.display = 'flex';
            } else {
                ref.current.style.display = 'none';
            }
        } else {
            ref.current.style.display = 'flex';
        }
    }, [menuActive]);

    this code make it so that, when i first resize the screen to mobile size, it automatically open the navs. i think instead of dynamically display or hide the mobile navs, instead you can modify the button to open and close the mobile menu. that way, you don't have to check whether the menu is active or not.

    keep on coding!

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    congratulations on completing the challenge! you can use localstorage to set the email for the purpose of this challenge https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage then, get the localstorage value, and inject it into DOM

    but in the real job scenario, i think you need to store it in some sort of database

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    congratulations on finishing the challenge! some friendly advice

    • on mobile screen (360px) , the main and main-container class is overflowing, i believe it's caused by the fixed with of 450px you set on the main tag. I would recommend setting the lower width, or not setting the width at all at this screen size as it will overflow.
    • you can scale down the image qr by adding some additional div to contain the width of the image and give padding to said div, or you can set the width manually.
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    i don't think it's cheating nor it's a bad idea at all with the rise of tools that could help us code like chatgpt, github copilot, it's actually very hard not to try those tools in real life working scenario, as long as you could solve the issue you are facing in your code, and could satisfy the client requirements, that's is a job well done, regardless of what tools you are using

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    congratulation on finishing the project! some friendly feedback for you

    • if you want to make the card centered vertically and horizontally, setting flex to a body and justify-content and align-items center might be the way, although you need to be careful implementing this when you have multiple items inside the body and they will be all centered.
    • the p tag is somewhat hard to see (having low contrast level), maybe you can change the color to other darker color so that it can be displayed nicely

    overall, well done on completing the project!

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    about flex and grid, it depends on the scenario. usually i use flex if the layout is rather simple and don't need tweaking about the exact width of each flex item, you can use that using flex basis but i didn't really like it. as for grid, you can use it on the components that require each grid item to have specific width, the exact example is header nav , where usually there is logo, nav links and icons.

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    the social media container in mobile version is way off, perhaps you can re tweak the share links. also, it is highly recommended for you to start designing for mobile version, so the media queries will be min-width, instead of max-width, hope it helps!

    Marked as helpful
  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    i think you misposition the karma card, but overall nicely done!

  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    nice job! for mobile page you need to use the media querries like : @media screen and (max-width : 345px(or so)) { //code here... } usually the flow is to make the mobile page first, so the media querries will be (min-width : 760px)..

    great job and keep up!

  • Azzy dvyastia kesuma•1,425
    @azzykesuma

    any feedback is really appreciated :)