All comments

• 

  Val• 95

  @el-shredders

  Submitted over 3 years ago

  Hi all! Here is my take on the todo app challenge. done in html/css and vanilla javascript. It's still not 100% finished:

  • i haven't implemented the drag and drop features (its a bit out of my league for now maybe)
  • I still have to do the "Clear Completed" feature.

  I'd still have reviews or advices from you guys on a few points.

  i m not sure I used the best Html structures to do this, for structure and semantics,

  it was my first time adding a theme switcher, i used a single data attribute in my body to get it done, if you have any suggestions to improve it

  I did the Js part in procedural programming, so it's a bit hard to keep everything clean (i tried my best and added lots of comments) So if you guys have any advice for me to keep my code cleaner or anything, i'll happily take it.

  And i was wondering if it was a good practice to kill the event listeners on a todo Element removal, if so what would be the best practice to do it?

  Thanks in advance Val

  

  To do App

  2

  15

  4

  

  Val• 95

  @el-shredders

  Posted over 3 years ago

  I can't seem to edit my solution, so litte update in the comments. I finished to implement the Clear completed feature, added the responsive part. And added the default list elements on first load via JS

  0
• 

  Val• 95

  @el-shredders

  Submitted over 3 years ago

  Hi all! Here is my take on the todo app challenge. done in html/css and vanilla javascript. It's still not 100% finished:

  • i haven't implemented the drag and drop features (its a bit out of my league for now maybe)
  • I still have to do the "Clear Completed" feature.

  I'd still have reviews or advices from you guys on a few points.

  i m not sure I used the best Html structures to do this, for structure and semantics,

  it was my first time adding a theme switcher, i used a single data attribute in my body to get it done, if you have any suggestions to improve it

  I did the Js part in procedural programming, so it's a bit hard to keep everything clean (i tried my best and added lots of comments) So if you guys have any advice for me to keep my code cleaner or anything, i'll happily take it.

  And i was wondering if it was a good practice to kill the event listeners on a todo Element removal, if so what would be the best practice to do it?

  Thanks in advance Val

  

  To do App

  2

  15

  4

  

  Val• 95

  @el-shredders

  Posted over 3 years ago

  And the project is in the master branch (i accidently gave the link to the main branch).

  3