All solutions

Hi all! Here is my take on the todo app challenge. done in html/css and vanilla javascript. It's still not 100% finished:

• i haven't implemented the drag and drop features (its a bit out of my league for now maybe)
• I still have to do the "Clear Completed" feature.

I'd still have reviews or advices from you guys on a few points.

i m not sure I used the best Html structures to do this, for structure and semantics,

it was my first time adding a theme switcher, i used a single data attribute in my body to get it done, if you have any suggestions to improve it

I did the Js part in procedural programming, so it's a bit hard to keep everything clean (i tried my best and added lots of comments) So if you guys have any advice for me to keep my code cleaner or anything, i'll happily take it.

And i was wondering if it was a good practice to kill the event listeners on a todo Element removal, if so what would be the best practice to do it?

Thanks in advance Val

I m quite happy with this project but...

I found myself stuck with a problem. I wanted the main image to grow with the width of the container (which was a grid cell), and keep growing past its full size. Couldn't find a solution, feels like the image was stuck to its original size. If anyone has been confronted with the same issue?

I'm not really happy with all the fixed values used in width, height box element etc. Feels a bit static. I tried to make the grid, font (...ect )grow with the size of the window, but did not succeed to keep a good ratio. I ended up doing it simple. Maybe i was trying to overcomplicate things for this project.

Any feedback, ideas welcome thanks

Hello, First challenge so far! I had trouble to find a good way to make the transition from the desktop view to mobile view. (eg font size, keeping a good w/h ratio on the grid cells)

Some Feedbacks would be greatly appreciated Thanks in advance Val