@maakosu2
Submitted
Tohid Dalaei Milan
@eng-milan
All comments
- Tohid Dalaei Milan• 410
@eng-milan
Posted
Beautiful, attractive app, well done. I just saw a very minor UI problem that I know you should have missed by mistake. In dark mode, input text colour in "filter by" is set to white which doesn't show options since its background is also white. Feature where user can go into country's detail and click on each border countries that takes user to detail of that country's detail is great. Again, well done with this lovely app.
Marked as helpful
0 @winsofttutorials
Submitted
I am still having issue with fixing screen 4 for the output of the selected plan, I sincerely do need help with that. My question what is the best approach to responsive design? Please I need help to fix that area.
Tohid Dalaei Milan• 410@eng-milan
Posted
Hi dear, I used Context API to store the plan and add-ons user selected and then accessed it in finishing-up stage(screen 4). You can define states for selected plan and add-ons in App component, update it inside desired component and pass states down to screen 4 component; But I think it will be more confusing and messy so using Context API would be a better option.
0- Emmanuel Ayeniko• 330
@NIKO-DEV06
Submitted
Had fun with this using Next js 13.3, feedback would be appreciated
Tohid Dalaei Milan• 410@eng-milan
Posted
It seemed impossible to me at first, but I came up with an idea that I am not sure if it is optimal or fast. I fetched whole countries object when app loads for the first time. Then passed that object with 250 countries all the way to every country detail page. There I took boundary array and mapped through each element to find corresponding country in 250 object and used its name to show up in component. To see more detail go to my solution's code. I am not pro so my code might be a mess but gladly I will clear things for you if you'd ask me.
0 - Emmanuel Ayeniko• 330
@NIKO-DEV06
Submitted
Had fun with this using Next js 13.3, feedback would be appreciated
Tohid Dalaei Milan• 410@eng-milan
Posted
Hi, First of all, bravo; absolutely lovely friendly app. One small recommendation, you can use api to convert border countries 3 letter name to full name so it would be more readable to users. And to take it further, you could create a link out of those border countries so once user clicks on those, it will take them to that countries' detail page. But again,I am so exited about your app and UI.
Marked as helpful
0 @ShahramMebashar
Submitted
Tohid Dalaei Milan• 410@eng-milan
Posted
well done. this one is a good smooth design in my opinion. It looks like your accessibility report shows 2 suggestions. 1.Document should have one main landmark which means you should add a main landmark to your main container. Either using <main></main> element instead of containing div or leave it as a div and give it a role of main like so <div role="main"></div> 2. Page should contain a level-one heading It wants us to add at least one h1 to the project. Since this project appears to have no main heading for h1, we can add a <h1> and give it a display of none.
Hope this'll help you. In the end again, very good job I liked it.
Marked as helpful
0- Clem FRontend• 20
@vivitare
Submitted
Hello everyone 👨💻
This is my first solution on Frontend Mentor 🎉
🛠️ Build with :
- React JS
📃 My questions :
- It's a good way to split CSS into multiple files like I did or it's better to put all the css in one file ?
- It's a good way to validate the form like I did ?
- What can I add to the index.html ?
Don't hesitate to tell me what can I improve (and i'm sure there are a lot of thing to say 🙄), it will be very useful for me !
Thanks ! 👋
Tohid Dalaei Milan• 410@eng-milan
Posted
Awsome design. I am also new and I am myself learning good practices so I won't be able to give you advise on your code bu UI is absolutely stunning.
To answer your question about css, React fundamental is about creating reusable components with disconnectivity to the whole project. So in my opinion if you create your own styles and not using css libraries, it's better to create separate css file for each component.
Hope this'll help.
Marked as helpful
1 - diegopaff• 60
@diegopaff
Submitted
Tohid Dalaei Milan• 410@eng-milan
Posted
Nice work and design. One thing I felt is not good experience for user is pre-defined text in boxes. If it was just placeholder and user could click in box and start typing is very comfortable, rather than selecting text in box and delete before typing their information. Hope this comment is helpful.
Marked as helpful
0 @XiomaraCanizales
Submitted
How is the layout of my site? Any suggestions on how to improve my JS skills?
Tohid Dalaei Milan• 410@eng-milan
Posted
Hi, nice looking page well done. If you could add functionality to unread notification that with click they will be marked as read, is a nice feature. What I mean is that not only clicking "Mark all as read" will make them read, but clicking each notification would mark it as read. This is what came to my mind at first glance.
Marked as helpful
0
