@angielxx
Submitted
- Are my class names appropriate?
- I don't know how to organize CSS codes.
Looking to hire developers?
@kostyafarber
@angielxx
Submitted
@kostyafarber
Posted
Hey there! 👋
Really great solution. It looks pixel perfect! Your CSS is very structured and looks clean.
Just a couple of suggestions:
:root
. It's best practise and looks a lot cleaner.index.html
has some commented out code. It will make it easier to read and more 'production ready'.BEM
convention. They provide an intuitive way to name your elements to make their meaning semantic. Check it out here.Really great work though! 🚀
Happy coding.
If you found my comment helpful please mark it as helpful 🙂
@Simply-huMAN
Submitted
How's my website design? How is the code for making this website? Is it complex or easy?
@kostyafarber
Posted
Hey there! 🚀
Really good solution, I like the way your code is laid out!
Just a couple of suggestions:
rem
or em
. They are more versatile and are more responsive than px
units.body {
font-family: Outfit;
margin: 0;
padding: 0;
box-sizing: border-box;
background: hsl(212, 45%, 89%);
}
main {
margin: 30px;
display: flex;
justify-items: center;
align-items: center;
}
Great work on this! 👏
Happy coding.
If you found this helpful, please mark it as helpful 🙂
Marked as helpful
@ayseakimsar
Submitted
I've struggled a bit to make the icon and the transparent color appear simultaneously. Also, I am unsure about the readability of my code. Other than those, it was a fun and quick project. Feedbacks welcome.
@kostyafarber
Posted
Hey there!
Really great solution 🚀 I think your code is well laid out and structured.
A couple of suggestions:
main
tag. It is good practise to use semantic HTML to make the structure of your page more readable. Every page should have a main
tag.::before
. This will reduce and declutter the html.Overall really good stuff.
Happy coding!
If you found my comment helpful please mark it as helpful! Thanks 🙂
Marked as helpful
@RayAsh37
Submitted
Hi everyone, I have been trying to practice layout. I am getting pretty confident with it. I have skipped the mobile layout as I plan to come later and implement it for all of my other solutions later. This was a bit simple compared to the ones I previously encountered.
@kostyafarber
Posted
Hey there!
Really great solution. I like how clean and organised your css is.
Just a couple of suggestions:
line-height
on the card content.Overall really good stuff.
Thanks, happy coding!
if you find my feedback helpful, please mark it as helpful. Thanks :)
Marked as helpful
@joshuayumul19
Submitted
@kostyafarber
Posted
Hi there!
Really great solution. Your SCSS is very well organised.
Just a couple of suggestions that you might find useful:
line-height
to the p
content. It would achieve the look in the design photo more closely.rem
, em
. They make for more responsive design across different browsers and devices, check out this articleOverall very strong solution with great code.
Happy coding!
If you find this solution helpful, please mark it as helpful :)
Marked as helpful
@petarchou
Submitted
@kostyafarber
Posted
Hey there!
Awesome solution. It looks great!
Just a couple of points of feedback if you don't mind!
main
tag as this represents the 'content' of your page see here@font-face
everywhere! You can just go on google fonts and use the @import url()
in your css.ctrl+alt+4
on a mac)Really good solution!
Happy coding!
if you found my feedback helpful please mark it as helpful :)
Marked as helpful
@hebrohim
Submitted
At first ,it was very difficult for me to use flexbox for a parent tag and its child tag, I had to visit w3schools to get better understanding of how it works
@kostyafarber
Posted
Hi there!
First of all well done! It looks great. Just a few suggestions
/* background-color: red; */
on line 41 in your CSS file.:root
, and then applying those to your elements. If you were to ever change them you would only have to do it in one place!alt
tags for your images. It improves accessibility.padding
on your divs to control how the text breaks when divs are resized. Adding br
may not be the best approach here!
Just a few tips, hope it was helpful and keep on coding!Marked as helpful