Moises• 60
@devmoises
Submitted
Practicing CSS Grid, I really like this property and I put my knowledge into practice, any contribution and help is welcome. Thanks.
Mohit Menghnani
@mmenghnani
All comments
- Mohit Menghnani• 55
@mmenghnani
Posted
This looks really great. I have a minor things that I was thinking upon
-
All img tags seem to have the photo class. Can you just use the img tag for the style?
-
For the alt text, should it just say Daniel Clifford or something like "image of Daniel Clifford". I am curious on this one myself
But I love this work, congrats and all the best. Cheers!
Marked as helpful
0 -
- Abhineet Kandele• 320
@abhineetkandele
Submitted
Any feedbacks are highly appreciated.
Thanks in advance!!
Mohit Menghnani• 55@mmenghnani
Posted
This is amazing. Great work abhineet!
If I really had to nit pick something, I had 2 questions
-
Why did you choose a p tag for the price amounts? Like an h tag would have been better sematically? No?
-
How are you using the annual and monthly class?
Just curious, but otherwise I love the work
0 -
@PedroHigueraG
Submitted
All suggestions are welcome
Mohit Menghnani• 55@mmenghnani
Posted
Hi Pedro, this looks really great. Just a few nitpicks I noted,
-
The height changes when you hover over the buttons. I don't think that is intended behavior. You can just use the suggestion that patrick shared above!
-
Is there any specific reason why we can't directly use button tag in the stylesheet instead of creating a new button class
-
Also, small typo - all three images tags have the same alt text :)
Great work, :clapping
Marked as helpful
1-
