Omar
@omar-csdevAll comments
- @proabre@omar-csdev
Hi, you are missing input validation upon submission. Try clicking on the button before typing a valid email in and you'll see what I mean. They also require you to show an error state for the user. Check the design images provided by frontendmentor.
Also on smaller screen sizes you can scroll and see the confirmation message.
Marked as helpful - @0xabdulkhaliq@omar-csdev
hi, I noticed that there are repsonsive issues on larger screens. Mainly the bottom half of the screen on full width 24 inch monitors.
- @Haiko-E@omar-csdev
Hi, small tip: after submiting an invalid email you get an error hint which is good, but when you go ahead and try inputting a new email, the error hint stays there. If I didn't manage to make it clear, you can check out my submission on my profile from yesterday. Other than that looks good!
Marked as helpful - @CuriousFullStacks@omar-csdev
Hi, it looks good on large screens but not so much on smaller devices. I advice you to check that out and make it responsive using @media queries. Also on smaller devices the image should change to the mobile image provided in the files. You can achieve this using the <picture> tag, look that up it's not difficult. Good luck!
Marked as helpful - @void-404
- @tom-kelly9@omar-csdev
Hi, it looks fine on desktop view. But when you resize it towards 375px, it becomes clogged up sometimes. Go in dev tools and resize the window, you will notice between 700px width and 376px width that it's not as intended.
- @Ivan-Brcina@omar-csdev
Very minor thing that I tend to notice: you can adjust the font size or the width of the card to match which words are at which line. What I mean is if you look at your version and see the last line you can see two words, while the solution shows three words.
Apart from that, code seems good to me :)
Marked as helpful