Ryan Calacsan
@ryancalacsanAll comments
- P@sorengrey@ryancalacsan
Good work on getting it super close to the design! Upon quick inspection I did notice a few things that may be worth looking into.
-Your current email validation seems to work on leaving it blank but is not currently checking to be a valid email.
-I would take a look into your error icon positioning. While they are in place for your desktop view, once you get to the mobile view they fly off to the right.
-Lastly I would look into your media queries and or spacing when resizing your window. There is a point between the two where your text starts to get cut off.
I am happy to go into more detailed solutions if you'd like but if you're anything like me, I learn/retain better when trying to work things out on my own first :)
Overall, great job and happy coding!
Marked as helpful - @wanaz13@ryancalacsan
Yes, if you want to use a media query for the background of your mobile design you can reposition your background elements to be back in view. With your current code, if you resize your window you can see the circles move out of view as you shrink the width.
Marked as helpful