Soe Wai Yan Aung
@soewaiyanagAll comments
- @ibimina@soewaiyanag
Great job with functionality. But with design, I found that the dice button is not fully centered. When I check your code I found that you are using a fixed value for the right property which is right: 8rem. You can fix it by setting it's right to 50% and adding transform: translateX(-50%). It will center the dice no matter what size or width of the card. And give it border-radius 50% to get a full circle. And would be better if you fix your font size and font-weight. Other than that, well done with functionality, keep it up.
Marked as helpful - @PhoenixDev22@soewaiyanag
So you want to change fill on hover right? I solve it by creating SVG as a react component. Here is my submitting. But you can solve it with pure CSS too. If you are using vs-code copy the codes inside SVG. And paste it in HTML and treat it as an HTML element. Give it a className and also remove its inline fill attribute(must remove otherwise CSS won't work). Now you can modify fill with CSS.
Marked as helpful - @shinnthantminn@soewaiyanag
Nice work the solution is as perfect as the original design. And try to fix those ACCESSIBILITY ISSUES and HTML ISSUES as much as you can.
Marked as helpful