Looking to hire developers?
@soransh-singh
@stevanusfebrian
Submitted
i have a little bit issue with the flexbox property in my main section, that is my "justify-content: space between" to give space between my .main-text and .heroes isn't working in mozilla, but it looks fine in chrome. Any feedback to my problem much appreciated, thanks.
@soransh-singh
Posted
Great work....
feed back I have:
In mobile and tablet version you left unintentionally a border around the logos... and you can change cursor to pointer when hover over menu button...
I wished I could helped on the problem you asked but I don't know it's solution
@Filippo-B
Submitted
I got carried away with this! 😅 I added an animation to the background and the possibility to set your own deadline, if your browser supports the datetime-local input type. Furthermore, the default deadline is the next full moon, and the date comes from an API. In this way the countdown should always work. Let me know what you think! 😀
@soransh-singh
Posted
you understood the assignment and slayed it... it look awesome ...
I don't know why but there is a horizontal scroll on my device other than that you have done better than the project in every way...
the extra things you have done make it really cool ... i will try to implement something similar when I will do this project
@excalibur1702
Submitted
@soransh-singh
Posted
hey It looks great... and that drag and drop is really great...
I have a question!! ... How had you setup your repository for frontend-mentor ??? I want to setup my react project better way ... and your repository look well maintain
@anOldChild
Submitted
Hi, I'm new to using BEM and SCSS. Please help me to check:
@soransh-singh
Posted
BEM means Block Element Modifier
In your code Block will be .pricing-card
then in .pricing-card element will be the buttons and text so you will name them .pricing-card__btns .pricing-card__text
one card is different from the other cards so you need modify bg-clr and clr of that card then you can add modifier to it like .pricing-card--accent or something.
Similarly you can modify btns and text by adding class card__btns--accent card__text--accent.
you can look this link they have explained better.
@jonaaldas
Submitted
Did really fast and tried to change the color scheme lol
@soransh-singh
Posted
hey... you have put the devChallenges link instead of this challenge... btw this challenge looks gooddd...
@TechieStephen
Submitted
Really enjoyed this challenge. Any pointers much appreciated!! 👍
@soransh-singh
Posted
This looks great you have done great job.
Just before the breakpoint in desktop design, In footer the social media icons are overlapping the list next to them. Other than that everything is great.
Marked as helpful
@peterramirez18
Submitted
I am learning about fronend. This is my first project using html, scss and javascript. Thanks to frontend mentor for these challenges.
@soransh-singh
Posted
hey I can't see your code...
Around 730px to 754px you slider h1 look weird.
In mobile design nav button is not working.
Other than that your design look damn great, everything looks nice and you have done great job. and loved your sticky header on the top. I am going to update that on my challenge.
Marked as helpful
@Eugene44-hub
Submitted
Wow, this was a really nice project which changed my way of writing codes a little. Please i need a feedback about my project, and on what areas i should improve. Thanks.
@soransh-singh
Posted
It looks great you have done great job....
I think you should at
to add margin-right in class output and also border-radius in class output and button-containers
and you have implemented the calculator logic nicely
it will be more fun if you will add support for calculating negative numbers also if divide .6 by 3(.6/3) you will get a .19999999998 ... you can round off number to certain digits so it doesn't show too much 9's
Marked as helpful
@H0bG0blin9g
Submitted
I am abit confused with the accessibility issues I have regarding "landmarks". Im not entirely sure what they are, and even after some googling I have no idea how to solve this. Granted I have made use of divs instead of the semantic names like article (I never really got around to grasping the semantic names and have been using divs everywhere), etc, so im inclined to think the issue lies there, but im not sure what to do to solve this. Any help regarding the solution as well as the importance of this would mean a lot!
Otherwise, this is my first frontend mentor challenge. This took longer than I was anticipating. Im sure there are simpler ways to achieve what I did and probably with less code and more elegence, however I am surprised at how much of a learning experience this has been and look forward to more challenges.
I realised that the order in which you tackle the challenge can go a long way in maintaining your sanity - too much jumping back and forth made it confusing for me to fix some css issues, so in the end I started again and tried do things in a logical order as opposed to randomly targeting elements on the design.
Looking forward to some feedback from the community as well as seeing how everyone else has come up with their solutions!
@soransh-singh
Posted
It looks great ... You have done great job ... Kudos to you for completing your first challenge
@caldwelljt2
Submitted
This is the first time I've really tried to do my own thing at all in code. I got considerable help from a couple people in the Slack channel because I am trying to learn how people think through their design and keep parts usable for other implementations. It probably shows in my code because I'm doing a few things that aren't optimized (importing) that I know I could avoid.
Things that don't work right and I dont know how to fix or need help with:
What I know I did wrong and don't care for now (i'll tackle it in the future):
In short, I stopped my progress on learning Vue because I realized I had rather poor understanding of the DOM/html in general. I've done a lot more with back end and had to similarly stop along that progress to better understand core concepts.
Really, ANY feedback is welcome, but my preference is to tackle glaring errors or things that are "bad habits" up front.
@soransh-singh
Posted
It looks good... it's your first submission congrats... you have done a great job
@caldwelljt2
Submitted
This is the first time I've really tried to do my own thing at all in code. I got considerable help from a couple people in the Slack channel because I am trying to learn how people think through their design and keep parts usable for other implementations. It probably shows in my code because I'm doing a few things that aren't optimized (importing) that I know I could avoid.
Things that don't work right and I dont know how to fix or need help with:
What I know I did wrong and don't care for now (i'll tackle it in the future):
In short, I stopped my progress on learning Vue because I realized I had rather poor understanding of the DOM/html in general. I've done a lot more with back end and had to similarly stop along that progress to better understand core concepts.
Really, ANY feedback is welcome, but my preference is to tackle glaring errors or things that are "bad habits" up front.
@soransh-singh
Posted
In card.css .container-outside, Instead of setting width:450px set max-width: 450px and add some margin.
If you want to make it relative like when screen size increase width of card also increase you can use percentage(%) or you can use Vw.
Marked as helpful
@Shelcy
Submitted
Hi Frontend-mentor community 👋!
I solved this challenge using only css, if you have a recommendation or any comments, I will be grateful.
See you, best wishes🌼.
@soransh-singh
Posted
Greattt work ... I have never got those background images correct (neverrr.... I hold grudges toward those background images)
@jNembhard
Submitted
This one was definitely harder than expected. I won't say too much about it, but one trick I will mention is that Firefox developers released a new set of css commands including one called grid-template-rows: masonry. It will be supported by major browsers in the near future. Do what you will with that information. It might save you some development time.
@soransh-singh
Posted
I am a beginner at React and don't understand much of your code ....but you have slain this challenge...
@jNembhard
Submitted
This one was definitely harder than expected. I won't say too much about it, but one trick I will mention is that Firefox developers released a new set of css commands including one called grid-template-rows: masonry. It will be supported by major browsers in the near future. Do what you will with that information. It might save you some development time.
@soransh-singh
Posted
thisss looksss awesome ...... it feels great and look too good .... it feels perfect
@jchapar
Submitted
Would love any feedback! Using SASS and having partial files for different components really made my code feel cleaner and easier to navigate.
@soransh-singh
Posted
Awesome work ... it looks great...
@zaraag92
Submitted
I used validate.js for email validation, also PHPMailer.
@soransh-singh
Posted
the background looks awwwwwsome...
I think I should also add a background image in my challenge ... it makes it look better 10 times.
when I am writing the email address ... it's showing an error which is fine, but I think, it will be better if it validates when I click the button.
Marked as helpful
@Marufjan
Submitted
Any comments and feedbacks are welcome!
@soransh-singh
Posted
Hey ... your solution is nice and you have done really well...
small suggestion ... in your HTML file you had used a lot of div block which could have been easily avoided
for example line 36-42 in your index.html file
<div class="text">
<p>
Hello fellow shoppers! We're currently building our new fashion
store. Add your email below to stay up-to-date with announcements
and our launch deals.
</p>
</div>
instead you could have used
<p class="text">
Hello fellow shoppers! We're currently building our new fashion
store. Add your email below to stay up-to-date with announcements
and our launch deals.
</p>
@karthik-raja-g
Submitted
Hi all. I took this challenge mainly to try out styled components and Context api. Your feedback is much appreciated. Thanks
@soransh-singh
Posted
This is good you have done a great job...
@Toycobro
Submitted
Im pretty new at this and would love some feedback.
@soransh-singh
Posted
I was not expecting those link will open YouTube video :D ... you have doneee a great work ... it looks good.... your code is also well structured and easy to understand ... one thing you can change is to change class names from * .one .two .three * to * .suv .luxury .sedans * that will make it more easy understand your css code
Marked as helpful
@bangkitPk
Submitted
Hello everyone... This was my first challenge in frontend mentor. I'm happy with the final result, but it would be great if anyone can review my code and give suggestions about my solution. Thank you...
@soransh-singh
Posted
hello, you have done a great job.
I think you should increase the font-size of * .main-paragraph * ... other than that it's great
Marked as helpful
@javovaz
Submitted
Hello! My name is Javo. I'm new in DEV Community and every single feedback is more than welcome (and needed).
@soransh-singh
Posted
Hi , you have done a great job .
@ItsmeSauravSonu
Submitted
Please tell me for any improvement. Keep Coding. Thank you!
@soransh-singh
Posted
It looks great ... you have done a great job
Marked as helpful
@aminbabu
Submitted
CSS grid is a great tool to make web pages responsive. It gives all the control over the project. But as a beginner, it's hard to remember grid functionality. However, I'm happy with it.
@soransh-singh
Posted
I agree css grid is helpful for making projects responsive but remembering all its property is difficult so I used this cheat sheet grid.malven.co that i found in resource section of frotend mentor ... It's helpful for me .
Marked as helpful
@Developer3027
Submitted
I did not download to kit. This is built off the concept of the images. I used a image off unsplash. It was after I worked it up that I realized you can download the kit, however, I like this concept so this is what I am submitting. Surely I can not be the only one to have made this mistake. I set it up in a aws s3 bucket for review. When this form failed due to the s3 bucket http, I set up in Vercel. Hope you enjoy. Please comment.
@soransh-singh
Posted
Hello, this look really good ... and I liked your color and photo choice.
